[eventhubs] - Update checkpointstore to latest version of event-hubs #16261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorleger
requested review from
chradek,
HarshaNalluru and
richardpark-msft
as code owners
ghost
added
the
chradek
reviewed
Jul 7, 2021
| @@ -61,7 +61,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@azure/abort-controller": "^1.0.0", | |||
| "@azure/event-hubs": "^5.5.0", | |||
| "@azure/event-hubs": "^5.6.0", | |||
| "@azure/logger": "^1.0.0", | |||
| "@azure/storage-blob": "^12.4.1", | |||
There was a problem hiding this comment.
Doesn't storage-blob need to be updated as well?
There was a problem hiding this comment.
I'm not entirely sure how the set-dev.js script chooses versioning policies, but this was the minimal set of changes necessary to get the build passing again. I think it has something to do with @Azure/[email protected] being in the allowedAlternativeVersions entry
azure-sdk-for-js/common/config/rush/common-versions.json
Lines 44 to 50 in ce818c6
Although reading that comment it sounds like we should move off of 12.4.1 regardless as 12.6.0 has been out for a while. I can try it and see if things are behaving
maorleger
requested review from
deyaaeldeen,
mikeharder,
praveenkuttappan and
witemple-msft
as code owners
chradek
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
This resolves the build error when set-dev-version is run, ensuring that the @azure/core-tracing versions are compatible.