[service-bus] Final work to expose AMQP body type encoding publicly #15295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We completely missed the schedule messages code path. Added, with tests. - Consolidated the two files of AMQP messaging tests into the `public` branch so we also get min/max testing. Removed all references to non-published interfaces.
richardpark-msft
requested review from
bterlson,
chradek,
HarshaNalluru,
ramya-rao-a and
xirzec
as code owners
ghost
added
the
|
/azp run js - service-bus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - service-bus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chradek
approved these changes
May 17, 2021
sdk/servicebus/service-bus/test/public/amqpAnnotatedMessage.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: chradek <[email protected]>
- Use nullish coallescing for annotations check for partition key
|
/azp run js - service-bus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chradek
approved these changes
May 17, 2021
|
/azp run js - service-bus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Aug 3, 2021
Feature/morazmiz/swagger separation fixes (Azure#15295) * add missing types * change reference to resource and resourceWithEtag * extract userInfo to common file * . * add composite tag * add missing dataConnectorsCheckRequirements * add dataConnectorsCheckRequirements to readme * fix readme * . * fix errors in readme * add missing type * add missing types * . * . * remove changes with resource, resourceWithEtag, new tag * . * remove object * revert userInfo changes * fix true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing work to enable AMQP body type encoding:
publicbranch so we also get min/max testing. Removed all references to non-published interfaces.