Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] AmqpAnnotatedMessage followups #14886

Closed
HarshaNalluru opened this issue Apr 14, 2021 · 2 comments
Closed

[Service Bus] AmqpAnnotatedMessage followups #14886

HarshaNalluru opened this issue Apr 14, 2021 · 2 comments
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Apr 14, 2021

a. Custom logic to calculate absolute_expiry_time

Make sure the other languages have this


(.NET and JS have it #14786 (comment))

b. Re-evaluate the AmqpAnnotatedMessage interface for sending

UPDATE: removing this from the list of things to do - AmqpAnnotatedMessage is considered an advanced flow where developers are assumed to be familiar with which fields are usable and not-usable when sending. The work item here is just to makes sure there is a test that attempts to resend a received AmqpAnnotatedMessage.

...Since some of the properties that are applicable for the receive side are not applicable for send side such as below
- deliveryCount #14786 (comment)
- deliveryAnnotations #14786 (comment)
- CreationTime (gets overridden even if set by user) #14786 (comment)
- AbsoluteExpiry (gets overridden even if set by user) #14786 (comment)

c. Message field validation

As part of a recent change message field validation was moved into toRheaMessage. The validation needs to cover the AMQP message code path as well.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 14, 2021
@richardpark-msft richardpark-msft self-assigned this Apr 14, 2021
@richardpark-msft richardpark-msft added Client This issue points to a problem in the data-plane of the library. Service Bus labels Apr 14, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 14, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] May milestone Apr 15, 2021
@ramya-rao-a ramya-rao-a added the blocking-release Blocks release label Apr 15, 2021
@richardpark-msft
Copy link
Member

Item "b" is up for debate - no other languages are planning on adding any particular validation here. The reasoning is that customers that are using this workflow are familiar with AMQP and will not be confused about which fields would be reasonably set for sending vs receiving. My current thought is to strike it from the list, provided we can properly send messages with those fields.

@richardpark-msft
Copy link
Member

All work that was specifically for JS completed in a few PRs:

#15271: Reenabling the body type (temporarily disabled for 7.1.0 from the master branch
#15295: Adding in support for scheduleMessages()

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jun 18, 2021
Subscription t1 del (Azure#14886)

* sql t2 readme config

* readme config

* Update readme.python.md

* conflient resolve

* t1 config del

Co-authored-by: msyyc <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

3 participants