[event-hubs] add tests for cancellation #15094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
requested review from
HarshaNalluru,
ramya-rao-a and
richardpark-msft
as code owners
ghost
added
the
|
/azp run js - event-hubs - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| await client.initialize({ abortSignal, timeoutInMs: 60000 }); | ||
| throw new Error(TEST_FAILURE); | ||
| } catch (err) { | ||
| should.equal(err.name, "AbortError"); |
There was a problem hiding this comment.
Not fatal for this PR but it's sometimes nice to compare the message and name together (so if it fails you have the actual exception that got thrown).
Perhaps that's not as easy with the 'should' API as it would be with just assert.deepEqual({
name: err.name,
message: err.message
}, {
name: "AbortError",
message: "The operation was aborted."
})
There was a problem hiding this comment.
Yeah, this is definitely less easy using should. Maybe an MQ task will be moving to assert...
| const messages = [...errors].map((e) => e.message); | ||
| messages.sort(); | ||
| console.dir(messages); |
richardpark-msft
approved these changes
May 17, 2021
|
Subscribe does not support abortSignals. The way to stop it is to call close on either the object returned by the subscribe call, or the EventHubConsumerClient. |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 7, 2021
Updated examples to use non-global locations and added new flags (Azure#15094) Co-authored-by: Avi Jerafi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4422
Also address #13504 for event hubs by adding tests on the EventHubSender.send method.
The abort signal was plumbed through all the
initoperations to fix a separate bug as part of #14844 and was released in event-hubs version 5.5.1.This PR ensures we have cancellation tests for all of our public methods and internal init/send/receive methods.