Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service Bus][Event Hubs] Pass the abort signal to the AwaitableSender.send() method #13504

Closed
ramya-rao-a opened this issue Feb 1, 2021 · 1 comment
Closed

[Service Bus][Event Hubs] Pass the abort signal to the AwaitableSender.send() method #13504

ramya-rao-a opened this issue Feb 1, 2021 · 1 comment
Assignees
@chradek
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus
Milestone
[2021] June

Comments

@ramya-rao-a
Copy link
Contributor

We use the AwaitableSender from rhea-promise in both Service Bus and Event Hubs. While we have the abort signal supported in our publicly exposed send APIs, they were not plumbed through to the call in rhea-promise.

Now that amqp/rhea-promise#66 is merged, we can fix this after a new version of rhea-promise is available.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 1, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus labels Feb 1, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 1, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] March milestone Feb 1, 2021
@ramya-rao-a ramya-rao-a mentioned this issue Feb 1, 2021
Closed
@chradek chradek mentioned this issue Feb 19, 2021
Merged
@ramya-rao-a ramya-rao-a modified the milestones: [2021] March, [2021] April Mar 3, 2021
@chradek chradek modified the milestones: [2021] April, [2021] May Apr 6, 2021
@chradek chradek mentioned this issue Apr 29, 2021
Merged
@chradek chradek modified the milestones: [2021] May, [2021] June May 13, 2021
@chradek chradek mentioned this issue May 20, 2021
Merged
@chradek
Copy link
Contributor

chradek commented Jun 10, 2021

Closed by #15349, #15094 and #13826

@chradek chradek closed this as completed Jun 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chradek chradek

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus
Projects
None yet
Milestone
[2021] June
Development

No branches or pull requests
2 participants
@ramya-rao-a @chradek