[Service Bus (potentially EH)] Check if we're always passing in the abortSignal to retry<> and the underlying operation

[HarshaNalluru]

Check if we missed passing abortSignal in the core-amqp retry logic and add if it is required.

azure-sdk-for-js/sdk/core/core-amqp/src/retry.ts

Line 185 in 309a14b

result = await config.operation();

@richardpark-msft @chradek @ramya-rao-a

[ramya-rao-a]

The operation() in the retry config is a parameter less function intentionally because the retry function is agnostic to what the operation method needs. The abort signal is passed to retry() for the purpose of cancelling retries if the abort signal was fired. The same abort signal is to be used by the operation internally by the caller of retry() and should not be the responsibility of the retry() function

[richardpark-msft]

@ramya-rao-a - I think you and @HarshaNalluru are in agreement.

I believe this issue was created to make sure we are always passing the abortSignal in to both retry and the underlying operation. If there were any cases where we hadn't, then we could end up in a situation where retry will never actually terminate since the abortSignal only applied to retry, and the underlying operation just keeps going. This is what retry<> does, so it's not a design breakage, just a "bad" usage of retry by us.

So to resolve this we just need to examine our retry calls and make sure they're following this pattern.

Alternately we could change retry() to pass this but I think the window of time to do that has passed.

[ramya-rao-a]

I made a pass at all the places where we are calling retry() and can confirm that the abort signal is passed to each of these calls.
When looking at whether the operation being retried is using the abort signal itself, I found the below place not meeting the bar

• send() in messageSender: Now that Add cancellation support to all async operations amqp/rhea-promise#66 is merged, we can fix this after a new version of rhea-promise is available. Logged [Service Bus][Event Hubs] Pass the abort signal to the AwaitableSender.send() method #13504
• negotiateClaim calls when senders and receivers are created: [core-amqp] Make CbsClient.negotiateClaim cancellable #9988 is tracking this
• creating rhea links: [Event Hubs] Update all init() operations to take in cancellation token / aborter #4422 is tracking this