[Identity] Hotfix 1.2.5: Removing express #14521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove use of express in InteractiveBrowserCredential * Remove use of express in InteractiveBrowserCredential * Fix lint issues * Use hostname instead of host * Add changelog entry * Address feedback * Address feedback * lint * address feedback * address feedback * lint
ramya-rao-a
approved these changes
Mar 25, 2021
|
Hello @sadasant! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to get the new branch hotifx/identity_1.2.5 (based on hotfix/identity_1.2.4) ready for a new hotfix. This hotfix will only include the removal of express, as per this commit: commit link.
I have tested that the changes work using the same scripts I use to test master.
As always, feedback appreciated!