Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Investigate replacing Express with a lighter-weight http server solution #13465

Closed
sophiajt opened this issue Jan 28, 2021 · 2 comments · Fixed by #13800
Closed

[Identity] Investigate replacing Express with a lighter-weight http server solution #13465

sophiajt opened this issue Jan 28, 2021 · 2 comments · Fixed by #13800
Assignees
@sadasant
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
[2021] April

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Jan 28, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
As reported in #13103 (note: a customer-reported issue), the current Express-based solution may be bringing additional resource cost to Identity.

Describe the solution you'd like
We have a few possible options here:

  • We can investigate a lighter-weight solution to this, which could replace Express.
  • We could make the usage of Express (and interactive browser credential) optional.

Describe alternatives you've considered
See above
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 28, 2021
@sophiajt sophiajt mentioned this issue Jan 28, 2021
Closed
@sophiajt sophiajt added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Jan 28, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 28, 2021
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jan 29, 2021
@ramya-rao-a ramya-rao-a added the feature-request This issue requires a new behavior in the product in order be resolved. label Jan 29, 2021
@sophiajt sophiajt mentioned this issue Feb 15, 2021
Merged
@ramya-rao-a
Copy link
Contributor

#13800 has the changes needed to remove our dependency on express which is now in the master branch and will ship as part of our 2.0.0-beta.1 update.

It is worth shipping a v1 update with this change as v2 is not GA yet and it may take some time for people to take in a major version update.

Re-opening this issue to port the fix to v1

@ramya-rao-a ramya-rao-a reopened this Mar 24, 2021
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2021] April Mar 24, 2021
@sadasant
Copy link
Contributor

I've released a hotfix that includes this change: #14521 I'll close this!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
[2021] April
Development

Successfully merging a pull request may close this issue.

[Identity] Remove express sophiajt/azure-sdk-for-js
3 participants
@sadasant @sophiajt @ramya-rao-a