Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Config] FeatureFlag and SecretReference support #14342

Merged
56 commits merged into from
Apr 2, 2021
Merged

[App Config] FeatureFlag and SecretReference support #14342

56 commits merged into from
Apr 2, 2021

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Mar 17, 2021 •
edited
Loading

Reference: Azure/azure-sdk-for-net#18487
This PR adds the

  • FeatureFlag support
  • SecretReference support
  • Tests for both
  • Samples for both
  • Changelog
  • Links to the samples in the readme

richardpark-msft and others added 6 commits March 12, 2021 18:25
@richardpark-msft
Getting there - need to check all the flows but, for the most part, t…
8e0da71 
…he only signature that actually needs to change is setConfigurationSetting, and even then just to express that there are additional types that you can send in.
@richardpark-msft
Surface changes to support:
9992426 
- Users adding in their own sync tokens (received from EventGrid)
- Deserializing and working with FeatureFlags or KeyVaultReferences
@richardpark-msft
Update to SecretReference naming for consistency
e4a36bf
@richardpark-msft
Remove [key:string]: any's.
4153a91
Make isFeatureFlagClientFilter() handle multiple types of client filt…
5a178ed 
…ers with a string union as the parameter.
Updated with the new isFeatureFlagClientFilter
9a1d05b
@ghost ghost added the App Configuration Azure.ApplicationModel.Configuration label Mar 17, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@HarshaNalluru HarshaNalluru mentioned this pull request Mar 25, 2021
Merged
6 tasks
ghost pushed a commit that referenced this pull request Mar 26, 2021
@HarshaNalluru
[App Config] updateSyncToken method (#14507)
9a7195d 
### TODOs
- [x] Add the new `updateSyncToken` method to `AppConfigurationClient` 
  (Picked up pieces from @richardpark-msft's work here #14342.)
- [x] Add a unit test
- [x] ~~Hoping to add a live test by leveraging the eventgrid SDK~~
- [x] Changelog
- [x] Hold off merging - wait for 1.1.1 to be released
- [x] What's the new version number for preview? - `1.2.0-beta.1` fine?
  
Reference: PR from .NET Azure/azure-sdk-for-net#18487
@HarshaNalluru HarshaNalluru changed the title [App Config] FeatureFlag and SecretReference draft [App Config] FeatureFlag and SecretReference support Apr 1, 2021
richardpark-msft
richardpark-msft approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, some ideas. Nothing fatal, looks pretty good for a preview.

sdk/appconfiguration/app-configuration/src/appConfigurationClient.ts Outdated Show resolved Hide resolved
sdk/appconfiguration/app-configuration/review/app-configuration.api.md Show resolved Hide resolved
sdk/appconfiguration/app-configuration/src/featureFlag.ts Outdated Show resolved Hide resolved
sdk/appconfiguration/app-configuration/src/featureFlag.ts Outdated Show resolved Hide resolved
sdk/appconfiguration/app-configuration/src/featureFlag.ts Outdated Show resolved Hide resolved
sdk/appconfiguration/app-configuration/test/public/index.spec.ts Outdated Show resolved Hide resolved
sdk/appconfiguration/app-configuration/test/public/index.spec.ts Outdated Show resolved Hide resolved
sdk/appconfiguration/app-configuration/test/public/index.spec.ts Outdated Show resolved Hide resolved
sdk/appconfiguration/app-configuration/test/samplesForApiReview.ts Outdated Show resolved Hide resolved
sdk/appconfiguration/app-configuration/test/public/index.spec.ts Outdated Show resolved Hide resolved
@HarshaNalluru HarshaNalluru mentioned this pull request Apr 2, 2021
Closed
@HarshaNalluru
Copy link
Member Author

Thanks for the great starter code and for all the help @richardpark-msft!
bitmoji

chradek
chradek approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@chradek chradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one nit to mark an export as internal.

sdk/appconfiguration/app-configuration/src/keyvaultReference.ts Show resolved Hide resolved
@HarshaNalluru
Mark
3cc458e 
/**
 * @internal
 */
@ghost
Copy link

ghost commented Apr 2, 2021

Hello @HarshaNalluru!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 811cfae into Azure:master Apr 2, 2021
This was referenced Apr 4, 2021
Closed
Closed
Closed
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
@HarshaNalluru @vindicatesociety
[App Config] updateSyncToken method (Azure#14507)
a89dc8d 
### TODOs
- [x] Add the new `updateSyncToken` method to `AppConfigurationClient` 
  (Picked up pieces from @richardpark-msft's work here Azure#14342.)
- [x] Add a unit test
- [x] ~~Hoping to add a live test by leveraging the eventgrid SDK~~
- [x] Changelog
- [x] Hold off merging - wait for 1.1.1 to be released
- [x] What's the new version number for preview? - `1.2.0-beta.1` fine?
  
Reference: PR from .NET Azure/azure-sdk-for-net#18487
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
@HarshaNalluru @vindicatesociety
[App Config] FeatureFlag and SecretReference support (Azure#14342)
61be36c 
Reference: Azure/azure-sdk-for-net#18487
This PR adds the 
- [x] FeatureFlag support
- [x] SecretReference support
- [x] Tests for both
- [x] Samples for both
- [x] Changelog 
- [x] Links to the samples in the readme
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankane-msft seankane-msft seankane-msft left review comments

@chradek chradek chradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@xirzec xirzec Awaiting requested review from xirzec

@mssfang mssfang Awaiting requested review from mssfang

@pakrym pakrym Awaiting requested review from pakrym

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HarshaNalluru @pakrym @chradek @richardpark-msft @seankane-msft