[Identity] Version update after hotfix 1.2.4 #14124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ramya-rao-a
reviewed
Mar 5, 2021
sdk/identity/identity/CHANGELOG.md
Outdated
|
|
||
| ## 1.2.4-beta.2 (Unreleased) | ||
| ## 1.2.5-beta.1 (Unreleased) (Continues from 1.2.4-beta.1) |
There was a problem hiding this comment.
I would recommend adding this note on 1.2.4-beta.1 in the text under the header rather than the header itself. Same for 1.2.4
Also... since we are introducing a breaking change... shouldnt the major version be updated?
There was a problem hiding this comment.
major
Scary! 😅
That is true though. I'll do the change in this PR.
ramya-rao-a
reviewed
Mar 8, 2021
Co-authored-by: Ramya Rao <[email protected]>
|
Hello @sadasant! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ramya-rao-a
approved these changes
Mar 10, 2021
ghost
merged commit
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
This PR is to reconciliate master after the hotfix is released. Here's the hotfix PR: Azure#14123 Feedback appreciated!
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to reconciliate master after the hotfix is released.
Here's the hotfix PR: #14123
Feedback appreciated!