Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Hotfix 1.2.4 #14123

Merged
merged 1 commit into from
Mar 6, 2021
Merged

[Identity] Hotfix 1.2.4 #14123

merged 1 commit into from
Mar 6, 2021

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Mar 5, 2021

Take notice that the target branch for this PR is: hotfix/identity_1.2.4.

This PR intends to update the code available at the Identity release 1.2.3 to include two bug fixes:

I'm only concerned because the latest beta was 1.2.4-beta.1, and this hotfix is 1.2.4. So I'm guessing I'll need to mention that the beta changes were moved to 1.2.5-beta.1?

I've set the release date for this hotfix to be: 2021-03-08, let me know if that's ok.

In any case, feedback appreciated!

@sadasant sadasant self-assigned this Mar 5, 2021
@sadasant sadasant requested a review from schaabs as a code owner March 5, 2021 04:46
@ghost ghost added the Azure.Identity label Mar 5, 2021
@sadasant sadasant mentioned this pull request Mar 5, 2021
Merged
@ramya-rao-a
Copy link
Contributor

I'm only concerned because the latest beta was 1.2.4-beta.1. So I'm guessing I'll need to mention that the beta changes were moved to 1.2.5-beta.1?

That must have been a mistake. It should have been 1.3.0-beta.1 if the beta was meant to add new features. I doubt that the beta had only bug fixes. Let's go ahead with 1.2.4 hot fix release, but make sure that the next beta is 1.3.0-beta.1. We can add a note in the changelog for 1.2.4 that it does not contain the features introduced in 1.2.4-beta.1 which will be continued to work on in the next update of 1.3.0-beta.1

This PR intends to update the code available at the Identity release 1.2.3 to include two bug fixes:

I see a single commit. Did we try cherry picking commits? That usually makes it easier to review already reviewed code and ensures that we don't have any extra code sneaking in.

@sadasant
Copy link
Contributor Author

sadasant commented Mar 5, 2021

@ramya-rao-a I cherry picked the changes by hand 😅 it seemed easier to me at the moment!

@ramya-rao-a I agree with 1.3.0-beta.1 for the next beta release! Thank you for that

@sadasant sadasant merged commit 527a7b3 into Azure:hotfix/identity_1.2.4 Mar 6, 2021
@sadasant sadasant deleted the hotfix/identity_1.2.4-changes branch March 6, 2021 01:29
ghost pushed a commit that referenced this pull request Mar 10, 2021
@sadasant
[Identity] Version update after hotfix 1.2.4 (#14124)
461643a 
This PR is to reconciliate master after the hotfix is released.

Here's the hotfix PR: #14123

Feedback appreciated!
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
@sadasant @vindicatesociety
[Identity] Version update after hotfix 1.2.4 (Azure#14124)
a4b37a1 
This PR is to reconciliate master after the hotfix is released.

Here's the hotfix PR: Azure#14123

Feedback appreciated!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaabs schaabs schaabs approved these changes

@daviwil daviwil Awaiting requested review from daviwil

@maorleger maorleger Awaiting requested review from maorleger

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees

@sadasant sadasant

Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadasant @ramya-rao-a @schaabs