Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Changelog entry for the recent DeviceCodeCredential change #11475

Merged
merged 3 commits into from
Sep 30, 2020
Merged

[Identity] Changelog entry for the recent DeviceCodeCredential change #11475

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4c0c65
[Identity] Changelog entry for the recent DeviceCodeCredential change
sadasant Sep 24, 2020
73db3e7
Joining the entry lines
sadasant Sep 24, 2020
1feae28
Reordered and rephrased the plugin-json entry
sadasant Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/identity/identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# Release History

## 1.2.0-beta.2 (Unreleased)
- Reverted change in 1.2.0-beta.1 which moved @rollup/plugin-json from devDependencies to dependencies

- `DefaultAzureCredential` now by default shows the Device Code message on the console. This can still be overwritten with a custom behavior by specifying a function as the third parameter, `userPromptCallback`.
sadasant marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the default be to not prompt, especially since this shipped? This seems like a breaking, blocking behavior change as it waits for user input. In .NET, we have a boolean parameter to opt into interactive prompts (or go full-on pick-and-choose with an options class).

Please bear in mind, I'm only seeing this description, though. Perhaps I'm misinterpreting it having not seen the code review, but it really does seem to indicate you'll block on user input by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your time, Heath!

The changes in my PR only add a logger by default. They don't affect the blocking behavior.

- Reverted a change in 1.2.0-beta.1 which moved `@rollup/plugin-json` from `devDependencies` to `dependencies`. `@rollup/plugin-json` was placed as a dependency due to an oversight, and it is not a necessary dependency for `@azure/identity`.

## 1.2.0-beta.1 (2020-09-08)

Expand Down