[Identity] Changelog entry for the recent DeviceCodeCredential change

[sadasant]

This is an experiment. It's a separate PR with the changelog entry for this previous PR: #11355

I'm trying to separate the code changes from the changes related to documentation etc. I'm wondering if it is easier to review this this way or if I should always add the changelog entry as part of the PR with the code changes.

[ramya-rao-a]

I'm trying to separate the code changes from the changes related to documentation etc. I'm wondering if it is easier to review this this way or if I should always add the changelog entry as part of the PR with the code changes.

Generally, I recommend adding changelogs as part of the PR that contains the code changes simply to avoid the case where we forget to add them and get release time stress in collecting all the changelog entries. Having both in the same PR avoids the context switch that one would have when reviewing the second PR if it comes a while after the first one.

If it helps, you can consider review comments on the changelog in the first PR that has code changes as non blocking and always follow up in a second PR. Hopefully, as time goes, the first attempts would improve and not need followups

[heaths]

Shouldn't the default be to not prompt, especially since this shipped? This seems like a breaking, blocking behavior change as it waits for user input. In .NET, we have a boolean parameter to opt into interactive prompts (or go full-on pick-and-choose with an options class).

Please bear in mind, I'm only seeing this description, though. Perhaps I'm misinterpreting it having not seen the code review, but it really does seem to indicate you'll block on user input by default.

[sadasant]

Thank you for your time, Heath!

The changes in my PR only add a logger by default. They don't affect the blocking behavior.

[sadasant]

I'd like to state that I believe the number of feedback entries in this PR justifies separating it from the source code changes! Here we can focus on the changelogs, without conflating the implementation. The Implementation feedback happened to be very concise. These conversations, although wonderful and absolutely necessary, are in my perspective an entirely separate effort than the implementation.