Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced relative link with absolute links and remove locale #11317

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Replaced relative link with absolute links and remove locale #11317

merged 3 commits into from
Sep 18, 2020

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Sep 17, 2020 •
edited
Loading

The PR is to turn on the link check flag.

  1. Disable the relative links.
  2. Remove locale "en-us" from link.

Pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=542176&view=logs&j=0874ffeb-2919-5b4b-20de-16a97970b94c

@ghost ghost added Azure.Core App Configuration Azure.ApplicationModel.Configuration labels Sep 17, 2020
@sima-zhu sima-zhu self-assigned this Sep 17, 2020
@ghost ghost added Cosmos Event Hubs Service Bus Azure.Identity KeyVault Storage Storage Service (Queues, Blobs, Files) EngSys This issue is impacting the engineering system. Search Monitor Monitor, Monitor Ingestion, Monitor Query labels Sep 17, 2020
@sima-zhu sima-zhu marked this pull request as ready for review September 17, 2020 21:27
xirzec
xirzec approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are reasonable, but I do somewhat wish the change to remove en-us (which is very unobjectionable) was separate from making everything an absolute link.

I also notice that we're touching a lot of track1 packages here. I hope this doesn't result in us auto-publishing them simply because we've updated their READMEs? /cc @ramya-rao-a

The only downside of making everything an absolute link is it does prevent us from following links in local versions (e.g. when using the preview markdown feature in VSCode) but hopefully the link checker will prevent us from accidentally referencing the wrong filenames.

@sima-zhu sima-zhu mentioned this pull request Sep 17, 2020
Merged
@weshaggard weshaggard merged commit add2f4f into Azure:master Sep 18, 2020
@sima-zhu sima-zhu deleted the disable_relative_links branch September 18, 2020 03:13
@sima-zhu sima-zhu mentioned this pull request Sep 18, 2020
Merged
@ramya-rao-a
Copy link
Contributor

Thanks for looping me in @xirzec

@sima-zhu, @weshaggard,

This PR should not have included the Track 1 data plane packages that are auto-generated. Next time these are updated via the code generator, these changes would be lost. Please log an issue in https://github.com/Azure/autorest.typescript/ to request the changes you want in the readme file in auto-generated packages. Please ensure to mention that this change should happen in both v4 and v6 versions of the code generator.

I also agree with @xirzec that it would have been preferable if the removing of locale was in a separate PR than the one that had the absolute link changes

@weshaggard
Copy link
Member

Sorry @xirzec I missed your comments last night when I was trying to get these link update PRs in, they were causing some build storms due to the number of files touched so I was trying to get them in quickly.

After this change our link checker will start to fail for any links that are broken or that fail our link guidance (i.e. are relative, or contain locale).

As for track 1 we don't have a great way to exclude those from our link checker and we were already fixing everything else so we decided to fix them as well. We didn't realize the code-generation aspect of the MD files. @sima-zhu please follow-up to see what it would take to get the generated MD files fixed and if not we need to figure out a way to filter them in our link validation checks.

@xirzec @ramya-rao-a sorry about the misunderstanding with the track 1 files and let us know if there is any fallout because of that and we will help deal with it.

@ramya-rao-a
Copy link
Contributor

No fallout, we will make sure the code generator is updated appropriately.
I have reached out to @deyaaeldeen and @joheredi offline

@sima-zhu
Copy link
Contributor Author

Thanks @xirzec and @ramya-rao-a pointing this out! Please feel free to reach out to me if we need any extra handling for track 1 library.

XiaoningLiu added a commit that referenced this pull request Sep 24, 2020
@XiaoningLiu @changlong-liu
@azure-sdk @deyaaeldeen @sadasant @joheredi @sima-zhu @richardpark-msft @sarangan12 @xirzec @colawwj @ellismg @weshaggard @praveenkuttappan @DominikMe @ramya-rao-a @mohsin-mehmood
[Storage] Feature - Recursive ACL (#9689)
47b6b70 
* Sdk automation/@Azure arm operationalinsights (#10935)

* Generated from ba891b7274af8cb22ee173e1998b4145d2d8d98b

Adding a point get.

* version 4.0.0

Co-authored-by: SDK Automation <[email protected]>

* Increment package version after release of azure-cosmos (#11311)

* [Text Analytics] Ignore document index when parsing opinion pointers (#11302)

* [Text Analytics] Ignore Document Index

* adding a test

* update tests

* add recordings

* [Text Analytics] Update release date (#11313)

* [Text Analytics] Update release date for 5.1.0-beta.1

* format

* [core-http] Move challenge based auth to core-http (#11226)

* Begin move of challenge-based auth

* Begin move of challenge-based auth

* Remove keyvault-common

* Update paths

* Fixing paths after removing keyvault-common

* fixed bad dist-esm index.js references

* Update paths

* Update docs

* Add mock tests

* Add mock tests

Co-authored-by: Daniel Rodríguez <[email protected]>

* Revert "[core-http] Move challenge based auth to core-http (#11226)" (#11320)

This reverts commit 43033ff.

* [AnomalyDetector] Update AnomalyDetector README (#11110)

* Update AnomalyDetector README

* Update pto beta

* Update changelog

* Address PR comments

* Replaced relative link with absolute links and remove locale (#11317)

Replaced relative link with absolute links and remove locale

* Enable the link check on aggregate-report (#11330)

* Increment package version after release of azure-ai-text-analytics (#11315)

* [Tables] Enable recorded tests in CI (#11238)

* Enable recorded tests in CI

* Update test script

* Add pollyfill

* [Anomaly Detector] Add sample snippet to README (#11335)

* Add samples to readme

* Update changelog date

* [Core-http] Support xml namespaces (#11201)

* Prototype xmlns

* Update prototype

* Additional tests

* Address PR comments

* formatting

* Apply changes to core-client

* Address  comments

* update core-client api-extractor

* use getXmlObjectValue

* Increment package version after release of azure-ai-anomaly-detector (#11340)

* [event-hubs] Update docs to mention the checkpoint store updates made when the subscription is closed. (#11345)

As part of investigating #11316 we found it was non-obvious that we would be using the checkpoint store when closing. 

The reason we use it is when we close the subscription we also mark, in the checkpoint store, that the partitions are abandoned. This lets other consumers more quickly pick up abandoned partitions rather than forcing them to wait for an expiration interval and discover it.

Fixes #11316

* Add testcases for handling odata (#11321)

* Add testcases for handling odata

* Formatting code

* PR Comments

* Minor Formatting

* Update sdk/search/search-documents/src/odata.ts

Co-authored-by: Jeff Fisher <[email protected]>

* Update sdk/search/search-documents/src/odata.ts

Co-authored-by: Jeff Fisher <[email protected]>

Co-authored-by: Jeff Fisher <[email protected]>

* release arm-netapp (#10849)

* release arm-netapp

* Generated from efcb7ecf4722c919d5528c53671b124046badcdb

update netapp readme.java.md

* version change

Co-authored-by: SDK Automation <[email protected]>

* Sdk automation/@Azure arm hybridcompute (#11307)

* Generated from a35b1cd98e20d7c9b3c4fdcb23125b7ea85acca6

add alias for auto_rev_minor_version

* v2.0.0

Co-authored-by: SDK Automation <[email protected]>

* [Event Grid] Remove some 'en-us' from some links (#11185)

* [Identity] Fix broken eslint in the builds (#11354)

* [Identity] Fix broken eslint in the builds

* .eslintignore was being ignored

* Feedback by Deya

* [Abort Controller] Update linting and fix linting errors (#11269)

* update linting and fix linting errors

* update linting scripts

* formatting

* fix linting errors

* fixes

* fix

* run api-extractor

* include the shim files in shipped files

* use the unrolledup type declarations

* do not lint package.json

* still lint package.json

* remove the call to api-extractor from the npm build script

* simplify eslint commands

* only ship src types

* [Identity] Idea for the Device Code Credential Use Console Feature (#11355)

* [Identity] Idea for the Device Code Credential Use Console Feature

* Feedback by Schaab and Vinay

* [Key Vault] Use the swagger generated from the service 7.2-preview (#11370)

* swagger reference to 7.2-preview/keys.json

* generated update

* 7.2 on keys

* 7.2 preview on certs and secrets

* generated files for secrets and certs

* secrets and certs

* sticking the swagger change to a specific commit

* Add placeholder yml file for pipeline generation

* Smoke test failure due to rollup peer dependency error (#11372)

* Change to move @rollup/plugin-json as dev dependency

* Add client libraries for Azure Communication Services (#11385)

* Add Communication service mapping

* Communication - Add code owners and label triggers (#11401)

* Communication - Add code owners and label triggers

* [ESLint Plugin] fix docs link (#11400)

* Increment package version after release of azure-keyvault-admin (#11216)

* Sync eng/common directory with azure-sdk-tools repository for Tools PR 1022 (#11347)

* Disable smoke test for storage-blob-changefeed (#11406)

* [Core paging] Update linting scripts and auto linting (#11274)

* [Core paging] Update linting scripts and auto linting

* formatting changes

* addressing Jeff's comments

* fixes

* turn sideEffects back on

* adding comments to address Ramya's feedback

* a typo

* adding dist-esm/index.js back

* Update sdk/core/core-paging/.eslintrc.json

Co-authored-by: Ramya Rao <[email protected]>

* remove dist-esm/src from files in package.json

Co-authored-by: Ramya Rao <[email protected]>

* fix package.json (#11412)

* [Service Bus] Remove stream-browserify dependency (#11221)

* [Core asynciterator] Update linting scripts and apply auto linting and some formatting (#11272)

* update linting scripts

* edits

* turn off relevant rules and lint package.json back

* adding .eslintrc.json

* [service-bus] Fixing broken option - we renamed it to maxWaitTimeInMs a few previews back. (#11410)

* Communication: fix test-resources config (#11434)

* [core-http] Add NDJSON support (#11325)

* [EventGrid] Add Azure Communication Service Events (#11428)

This change adds typings for the new events sent by the Azure
Communication Services

* Sync eng/common directory with azure-sdk-tools repository for Tools PR 989 (#11214)

* [Cosmos] Adding missing copyright headers (#11449)

* [Service Bus] Type docs fix - Added @internal and @ignore tags for internal methods (#11427)

* logger, isError, toAmqpAnnotatedMessage changed to internal

* SubQueue renamed to _SubQueue and changed to internal for jsdoc

* Revert "SubQueue renamed to _SubQueue and changed to internal for jsdoc"

This reverts commit b97b682.

* [Storage] Recursive ACL swagger transform patch

* [Storage] Add support for recursive ACL

* [Storage] Recording for recursive ACL

* [Storage] Update changelog for recursive acl

* [Storage] Add comments for recursive ACL parameters; Resolve review comments

* Add continueOnFailure option for set AccessControlRecursive methods

* Removed PathSetAccessControlRecursiveMode from public API list

* Update AccessControlChangeFailure to AccessControlChangeError with typical name and message properties

* Resolve build failures

* Resolve build failures

Co-authored-by: changlong-liu <[email protected]>
Co-authored-by: SDK Automation <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: Jonathan Turner <[email protected]>
Co-authored-by: Daniel Rodríguez <[email protected]>
Co-authored-by: Jose Manuel Heredia Hidalgo <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Richard Park <[email protected]>
Co-authored-by: Sarangan Rajamanickam <[email protected]>
Co-authored-by: Jeff Fisher <[email protected]>
Co-authored-by: colawwj <[email protected]>
Co-authored-by: Matt Ellis <[email protected]>
Co-authored-by: Daniel Rodríguez <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: praveenkuttappan <[email protected]>
Co-authored-by: Dominik <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Ramya Rao <[email protected]>
Co-authored-by: Jeff Fisher <[email protected]>
Co-authored-by: Mohsin Mehmood <[email protected]>
ljian3377 added a commit that referenced this pull request Oct 13, 2020
@ljian3377 @XiaoningLiu
@changlong-liu @azure-sdk @deyaaeldeen @sadasant @joheredi @sima-zhu @richardpark-msft @sarangan12 @xirzec @colawwj @ellismg @weshaggard @praveenkuttappan @DominikMe @ramya-rao-a @mohsin-mehmood
[storage] stg74 (#11459)
0a567a0 
* [storage][stg74] swagger update (#11171)

* build:autorest

* f7425b8

* update service and pacakge versions

* queue updateMessage protocol layer breaking change

* createPermissionOperationSpec.isXML=false

* regenerate with 3360920245f8c06e10f5e349ce3dca5e4d10372e

* fix ae-forgotten-export

Co-authored-by: Lin Jian <[email protected]>

* swagger-regenerate: 196d5c1

* smb multi-channel (#11178)

* [Storage] Feature - Recursive ACL (#9689)

* Sdk automation/@Azure arm operationalinsights (#10935)

* Generated from ba891b7274af8cb22ee173e1998b4145d2d8d98b

Adding a point get.

* version 4.0.0

Co-authored-by: SDK Automation <[email protected]>

* Increment package version after release of azure-cosmos (#11311)

* [Text Analytics] Ignore document index when parsing opinion pointers (#11302)

* [Text Analytics] Ignore Document Index

* adding a test

* update tests

* add recordings

* [Text Analytics] Update release date (#11313)

* [Text Analytics] Update release date for 5.1.0-beta.1

* format

* [core-http] Move challenge based auth to core-http (#11226)

* Begin move of challenge-based auth

* Begin move of challenge-based auth

* Remove keyvault-common

* Update paths

* Fixing paths after removing keyvault-common

* fixed bad dist-esm index.js references

* Update paths

* Update docs

* Add mock tests

* Add mock tests

Co-authored-by: Daniel Rodríguez <[email protected]>

* Revert "[core-http] Move challenge based auth to core-http (#11226)" (#11320)

This reverts commit 43033ff.

* [AnomalyDetector] Update AnomalyDetector README (#11110)

* Update AnomalyDetector README

* Update pto beta

* Update changelog

* Address PR comments

* Replaced relative link with absolute links and remove locale (#11317)

Replaced relative link with absolute links and remove locale

* Enable the link check on aggregate-report (#11330)

* Increment package version after release of azure-ai-text-analytics (#11315)

* [Tables] Enable recorded tests in CI (#11238)

* Enable recorded tests in CI

* Update test script

* Add pollyfill

* [Anomaly Detector] Add sample snippet to README (#11335)

* Add samples to readme

* Update changelog date

* [Core-http] Support xml namespaces (#11201)

* Prototype xmlns

* Update prototype

* Additional tests

* Address PR comments

* formatting

* Apply changes to core-client

* Address  comments

* update core-client api-extractor

* use getXmlObjectValue

* Increment package version after release of azure-ai-anomaly-detector (#11340)

* [event-hubs] Update docs to mention the checkpoint store updates made when the subscription is closed. (#11345)

As part of investigating #11316 we found it was non-obvious that we would be using the checkpoint store when closing. 

The reason we use it is when we close the subscription we also mark, in the checkpoint store, that the partitions are abandoned. This lets other consumers more quickly pick up abandoned partitions rather than forcing them to wait for an expiration interval and discover it.

Fixes #11316

* Add testcases for handling odata (#11321)

* Add testcases for handling odata

* Formatting code

* PR Comments

* Minor Formatting

* Update sdk/search/search-documents/src/odata.ts

Co-authored-by: Jeff Fisher <[email protected]>

* Update sdk/search/search-documents/src/odata.ts

Co-authored-by: Jeff Fisher <[email protected]>

Co-authored-by: Jeff Fisher <[email protected]>

* release arm-netapp (#10849)

* release arm-netapp

* Generated from efcb7ecf4722c919d5528c53671b124046badcdb

update netapp readme.java.md

* version change

Co-authored-by: SDK Automation <[email protected]>

* Sdk automation/@Azure arm hybridcompute (#11307)

* Generated from a35b1cd98e20d7c9b3c4fdcb23125b7ea85acca6

add alias for auto_rev_minor_version

* v2.0.0

Co-authored-by: SDK Automation <[email protected]>

* [Event Grid] Remove some 'en-us' from some links (#11185)

* [Identity] Fix broken eslint in the builds (#11354)

* [Identity] Fix broken eslint in the builds

* .eslintignore was being ignored

* Feedback by Deya

* [Abort Controller] Update linting and fix linting errors (#11269)

* update linting and fix linting errors

* update linting scripts

* formatting

* fix linting errors

* fixes

* fix

* run api-extractor

* include the shim files in shipped files

* use the unrolledup type declarations

* do not lint package.json

* still lint package.json

* remove the call to api-extractor from the npm build script

* simplify eslint commands

* only ship src types

* [Identity] Idea for the Device Code Credential Use Console Feature (#11355)

* [Identity] Idea for the Device Code Credential Use Console Feature

* Feedback by Schaab and Vinay

* [Key Vault] Use the swagger generated from the service 7.2-preview (#11370)

* swagger reference to 7.2-preview/keys.json

* generated update

* 7.2 on keys

* 7.2 preview on certs and secrets

* generated files for secrets and certs

* secrets and certs

* sticking the swagger change to a specific commit

* Add placeholder yml file for pipeline generation

* Smoke test failure due to rollup peer dependency error (#11372)

* Change to move @rollup/plugin-json as dev dependency

* Add client libraries for Azure Communication Services (#11385)

* Add Communication service mapping

* Communication - Add code owners and label triggers (#11401)

* Communication - Add code owners and label triggers

* [ESLint Plugin] fix docs link (#11400)

* Increment package version after release of azure-keyvault-admin (#11216)

* Sync eng/common directory with azure-sdk-tools repository for Tools PR 1022 (#11347)

* Disable smoke test for storage-blob-changefeed (#11406)

* [Core paging] Update linting scripts and auto linting (#11274)

* [Core paging] Update linting scripts and auto linting

* formatting changes

* addressing Jeff's comments

* fixes

* turn sideEffects back on

* adding comments to address Ramya's feedback

* a typo

* adding dist-esm/index.js back

* Update sdk/core/core-paging/.eslintrc.json

Co-authored-by: Ramya Rao <[email protected]>

* remove dist-esm/src from files in package.json

Co-authored-by: Ramya Rao <[email protected]>

* fix package.json (#11412)

* [Service Bus] Remove stream-browserify dependency (#11221)

* [Core asynciterator] Update linting scripts and apply auto linting and some formatting (#11272)

* update linting scripts

* edits

* turn off relevant rules and lint package.json back

* adding .eslintrc.json

* [service-bus] Fixing broken option - we renamed it to maxWaitTimeInMs a few previews back. (#11410)

* Communication: fix test-resources config (#11434)

* [core-http] Add NDJSON support (#11325)

* [EventGrid] Add Azure Communication Service Events (#11428)

This change adds typings for the new events sent by the Azure
Communication Services

* Sync eng/common directory with azure-sdk-tools repository for Tools PR 989 (#11214)

* [Cosmos] Adding missing copyright headers (#11449)

* [Service Bus] Type docs fix - Added @internal and @ignore tags for internal methods (#11427)

* logger, isError, toAmqpAnnotatedMessage changed to internal

* SubQueue renamed to _SubQueue and changed to internal for jsdoc

* Revert "SubQueue renamed to _SubQueue and changed to internal for jsdoc"

This reverts commit b97b682.

* [Storage] Recursive ACL swagger transform patch

* [Storage] Add support for recursive ACL

* [Storage] Recording for recursive ACL

* [Storage] Update changelog for recursive acl

* [Storage] Add comments for recursive ACL parameters; Resolve review comments

* Add continueOnFailure option for set AccessControlRecursive methods

* Removed PathSetAccessControlRecursiveMode from public API list

* Update AccessControlChangeFailure to AccessControlChangeError with typical name and message properties

* Resolve build failures

* Resolve build failures

Co-authored-by: changlong-liu <[email protected]>
Co-authored-by: SDK Automation <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: Jonathan Turner <[email protected]>
Co-authored-by: Daniel Rodríguez <[email protected]>
Co-authored-by: Jose Manuel Heredia Hidalgo <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Richard Park <[email protected]>
Co-authored-by: Sarangan Rajamanickam <[email protected]>
Co-authored-by: Jeff Fisher <[email protected]>
Co-authored-by: colawwj <[email protected]>
Co-authored-by: Matt Ellis <[email protected]>
Co-authored-by: Daniel Rodríguez <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: praveenkuttappan <[email protected]>
Co-authored-by: Dominik <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Ramya Rao <[email protected]>
Co-authored-by: Jeff Fisher <[email protected]>
Co-authored-by: Mohsin Mehmood <[email protected]>

* lastAccessed in BlobDownloadResponse wrapper

* [storage][stg74] container restore (#11457)

* interface

* includeDeleted

* [storage][stg74] get file range diff (#11455)

* wip

* circular dependency

* move share, dirctory and file clients to the same file

* swagger-regeneration: df297c8

* get file range diff

* nit: PR comments

* [storage][stg74] quick query new output format "arrow" (#11423)

* quick query new outputSerialization "arrow"

* for datalake, and remove preprod

* [storage][stg74] Delegation SAS v2 and Directory SAS (#11395)

* move under sas/

* wip

* wip

* test wip

* autofill directoryDepth

* update allow optional messageText (#11258)

* [storage][stg74] 4TB file for standard account (#11177)

* build:autorest

* update service and pacakge versions

* createPermissionOperationSpec.isXML=false

* test create, resize, uploadRange for 4tb file with a preprod account

* record test then manually remove preprod from recording file, fix documentation

* update comments 1TB -> 4TB

Co-authored-by: Lin Jian <[email protected]>

* add set expiry (#11461)

Co-authored-by: Lin Jian <[email protected]>

* fix merge issue

* Continuation Token wrapped with Error when Recursive Acl call is interrupted (#11716)

* [storage][stg74] address PR comments (#11520)

* wip

* overload SASQueryParameters constructor

* api extract

* Rename leaseTime -> leaseTimeInSeconds

* share lease tests

* container restore test wip

* restore container test fixed

* fix CI

* make options optional and add comments

* [storage][stg74] set file tier (#11735)

* format datalake

* re-generate file with de8a4f0

* add set share tier

* edit import

* [storage] temporary fix for issue #11505 (#11737)

* temporary fix for issue #11505

* format

* update pacakge versions and change log (#11739)

* [storage][stg74] fix ci (#11752)

* use beta

* fix listContainers when include = []

* fix CI

* unskip quick query record & support include-leased for x-ms-delete-snapshots (#11754)

* Resolve CRI failure (#11756)

* fix lease test case

* Record RecAcl (#11765)

* [storage][stg74] test coverage improvement (#11757)

* use preview for blob and use defaultCredential in datalake

* use preview subscription for datalake

* turn on log

* throw when accountName is invalid

* CONTAINER_SOFT_DELETE_

* set cors in service properties

* PREMIUM_FILE_

* blob remove .only

* SOFT_DELETE_ for both blob and share

* unskip a tag case

* unskip all f,t cases in browser

* file use production subscription

* add role for datalakeAccount

* me

* undo datalake roleAssignment

* unskip blob delegation SAS cases via using DefaultCredential

* add blobDataOwnerRoleId

* premiumFileAccountName

* me

* unskip last access tracking case

* me

* delegation sas refactor

* fix CI

* getRangeListDiff .only

* run all cases in file

* skip getRangeListDiff in live tests

* rename and add comments

* last access

* skip LAT

* me

* re-record blob delegation SAS cases

* modify testutils and re-record

* record for browser

* me

* fix CI and unskip cases

* tune setProperties in IE

* remove .only

Co-authored-by: Lin Jian <[email protected]>
Co-authored-by: xiaonlimsft <[email protected]>
Co-authored-by: changlong-liu <[email protected]>
Co-authored-by: SDK Automation <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Co-authored-by: Jonathan Turner <[email protected]>
Co-authored-by: Daniel Rodríguez <[email protected]>
Co-authored-by: Jose Manuel Heredia Hidalgo <[email protected]>
Co-authored-by: Sima Zhu <[email protected]>
Co-authored-by: Richard Park <[email protected]>
Co-authored-by: Sarangan Rajamanickam <[email protected]>
Co-authored-by: Jeff Fisher <[email protected]>
Co-authored-by: colawwj <[email protected]>
Co-authored-by: Matt Ellis <[email protected]>
Co-authored-by: Daniel Rodríguez <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: praveenkuttappan <[email protected]>
Co-authored-by: Dominik <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Co-authored-by: Ramya Rao <[email protected]>
Co-authored-by: Jeff Fisher <[email protected]>
Co-authored-by: Mohsin Mehmood <[email protected]>
ghost pushed a commit to Azure/azure-sdk-tools that referenced this pull request Oct 19, 2020
@sima-zhu
Enable the link check for link verification step. (#1019)
370df1b 
This is the final step of link verification epic. 

Enable the link guidance check for all Ci pipelines.

The PR is pending for all lang PRs:
java: Azure/azure-sdk-for-java#15285
net: Azure/azure-sdk-for-net#15223
python: Azure/azure-sdk-for-python#13846
js: Azure/azure-sdk-for-js#11317
ios: Azure/azure-sdk-for-ios#433
android: Azure/azure-sdk-for-android#348
go: Azure/azure-sdk-for-go#12541
cpp: Azure/azure-sdk-for-cpp#632
c: Azure/azure-sdk-for-c#1296
benbp pushed a commit to Azure/azure-sdk-tools that referenced this pull request Dec 1, 2020
@sima-zhu @benbp
Enable the link check for link verification step. (#1019)
4017a2a 
This is the final step of link verification epic. 

Enable the link guidance check for all Ci pipelines.

The PR is pending for all lang PRs:
java: Azure/azure-sdk-for-java#15285
net: Azure/azure-sdk-for-net#15223
python: Azure/azure-sdk-for-python#13846
js: Azure/azure-sdk-for-js#11317
ios: Azure/azure-sdk-for-ios#433
android: Azure/azure-sdk-for-android#348
go: Azure/azure-sdk-for-go#12541
cpp: Azure/azure-sdk-for-cpp#632
c: Azure/azure-sdk-for-c#1296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@xirzec xirzec xirzec approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@chradek chradek Awaiting requested review from chradek

@danieljurek danieljurek Awaiting requested review from danieljurek

@daviwil daviwil Awaiting requested review from daviwil

@ellismg ellismg Awaiting requested review from ellismg

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@jiacfan jiacfan Awaiting requested review from jiacfan

@sophiajt sophiajt Awaiting requested review from sophiajt

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

@ljian3377 ljian3377 Awaiting requested review from ljian3377

@markwolff markwolff Awaiting requested review from markwolff

@mikeharder mikeharder Awaiting requested review from mikeharder

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft

@sadasant sadasant Awaiting requested review from sadasant

@sarangan12 sarangan12 Awaiting requested review from sarangan12

@schaabs schaabs Awaiting requested review from schaabs

@southpolesteve southpolesteve Awaiting requested review from southpolesteve

@vinjiang vinjiang Awaiting requested review from vinjiang

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu

@zfoster zfoster Awaiting requested review from zfoster

Assignees

@sima-zhu sima-zhu

Labels
App Configuration Azure.ApplicationModel.Configuration Azure.Core Azure.Identity Cosmos EngSys This issue is impacting the engineering system. Event Hubs KeyVault Monitor Monitor, Monitor Ingestion, Monitor Query Search Service Bus Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sima-zhu @ramya-rao-a @weshaggard @xirzec