Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced relative link with absolute links and remove locale #15285

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Replaced relative link with absolute links and remove locale #15285

merged 3 commits into from
Sep 18, 2020

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Sep 16, 2020 •
edited
Loading

The PR is to turn on the link check flag.

  1. Disable the relative links.
  2. Remove locale "en-us" from link.

Pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=541050&view=logs&j=ad792ccc-30b2-59a1-5b53-546a79d88828&t=98098dc8-5acb-5f94-5428-670dacfec5e2

@sima-zhu
Copy link
Contributor Author

/azp run java - aggregate-reports

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@sima-zhu sima-zhu force-pushed the disable_relative_link branch 7 times, most recently from 8b4eb0b to 32e609a Compare September 17, 2020 03:24
@sima-zhu sima-zhu changed the title Turn on the feature of disabling relative link, replaced relative link with absolute links Replaced relative link with absolute links and remove locale Sep 17, 2020
@sima-zhu sima-zhu marked this pull request as ready for review September 17, 2020 04:57
@sima-zhu sima-zhu self-assigned this Sep 17, 2020
@sima-zhu sima-zhu added the EngSys This issue is impacting the engineering system. label Sep 17, 2020
mssfang
mssfang approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@mssfang mssfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for AppConfig, TextAnalytics and FormRecognizer changes! Thanks Sima.

@sima-zhu sima-zhu mentioned this pull request Sep 17, 2020
Merged
weidongxu-microsoft
weidongxu-microsoft approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

@weshaggard
Copy link
Member

I was expecting you to enable the link guidance as part of this PR so that we can confirm that we have all the links fixed, but I didn't see that as part of this PR.

@weshaggard
Copy link
Member

/azp run java - aggregate-reports

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@weshaggard
Copy link
Member

Manually triggered java - aggregate-reports jobs https://dev.azure.com/azure-sdk/internal/_build/results?buildId=542853&view=logs&j=ad792ccc-30b2-59a1-5b53-546a79d88828 to verify.

weshaggard
weshaggard reviewed Sep 18, 2020
View reviewed changes
eng/pipelines/templates/jobs/archetype-sdk-client.yml
@@ -164,6 +157,7 @@ jobs:
- template: ../../../common/pipelines/templates/steps/verify-links.yml
parameters:
Directory: sdk/${{ parameters.ServiceDirectory }}
CheckLinkGuidance: $true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might also need to be set for the aggregate-reports pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not enable aggregate-report yml. Will trigger the aggregate-report again once I check in the changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Ok with that as long as you quickly follow-up on any broken links as I want to make sure we don't accidently break any pipelines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to work on lang repos subsequently as work altogether will cause a spike unfortunately.

weshaggard
weshaggard approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick scan looks good. Lets wait for the java - aggregate-reports pipeline so it can validate all the links in the repo

@weshaggard
Copy link
Member

@sima-zhu I'm going to force merge this right now. Please follow-up with a change the aggregate-reports pipeline to enable the guidance so that we can ensure there are no other breaks.

@weshaggard weshaggard merged commit db22574 into Azure:master Sep 18, 2020
@sima-zhu sima-zhu deleted the disable_relative_link branch September 18, 2020 02:55
@sima-zhu sima-zhu mentioned this pull request Sep 18, 2020
Merged
ghost pushed a commit to Azure/azure-sdk-tools that referenced this pull request Oct 19, 2020
@sima-zhu
Enable the link check for link verification step. (#1019)
370df1b 
This is the final step of link verification epic. 

Enable the link guidance check for all Ci pipelines.

The PR is pending for all lang PRs:
java: Azure/azure-sdk-for-java#15285
net: Azure/azure-sdk-for-net#15223
python: Azure/azure-sdk-for-python#13846
js: Azure/azure-sdk-for-js#11317
ios: Azure/azure-sdk-for-ios#433
android: Azure/azure-sdk-for-android#348
go: Azure/azure-sdk-for-go#12541
cpp: Azure/azure-sdk-for-cpp#632
c: Azure/azure-sdk-for-c#1296
benbp pushed a commit to Azure/azure-sdk-tools that referenced this pull request Dec 1, 2020
@sima-zhu @benbp
Enable the link check for link verification step. (#1019)
4017a2a 
This is the final step of link verification epic. 

Enable the link guidance check for all Ci pipelines.

The PR is pending for all lang PRs:
java: Azure/azure-sdk-for-java#15285
net: Azure/azure-sdk-for-net#15223
python: Azure/azure-sdk-for-python#13846
js: Azure/azure-sdk-for-js#11317
ios: Azure/azure-sdk-for-ios#433
android: Azure/azure-sdk-for-android#348
go: Azure/azure-sdk-for-go#12541
cpp: Azure/azure-sdk-for-cpp#632
c: Azure/azure-sdk-for-c#1296
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jul 22, 2021
CodeGen from PR 15285 in Azure/azure-rest-api-specs
e5248ab 
Updating version in readme (Azure#15285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@mssfang mssfang mssfang approved these changes

@samvaity samvaity samvaity approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy

@bsiegel bsiegel Awaiting requested review from bsiegel

@danieljurek danieljurek Awaiting requested review from danieljurek

@David-Noble-at-work David-Noble-at-work Awaiting requested review from David-Noble-at-work

@g2vinay g2vinay Awaiting requested review from g2vinay

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@joshfree joshfree Awaiting requested review from joshfree

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@sjkwak sjkwak Awaiting requested review from sjkwak

@vcolin7 vcolin7 Awaiting requested review from vcolin7

@zhoufenqin zhoufenqin Awaiting requested review from zhoufenqin

Assignees

@sima-zhu sima-zhu

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sima-zhu @weshaggard @samvaity @mssfang @alzimmermsft @weidongxu-microsoft