[EventHubs][DistributedTracing] add destination and peer.address attributes #10389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwolff
requested review from
chradek,
HarshaNalluru,
ramya-rao-a and
richardpark-msft
as code owners
ghost
added
the
markwolff
changed the title
markwolff
changed the title
|
/azp run js - eventhubs-client - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chradek
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
@markwolff
Thanks, this looks great! Can you also add a changelog entry? There's an example for a similar update here: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/eventhub/event-hubs/CHANGELOG.md#tracing-updates
Other than that, assuming ci passes, looks good to me!
|
/azp run js - eventhubs-client - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function parameter to add
message_bus.destinationandpeer.addressattributes to spans created underAzure.EventHubs.message.Fixes #10276
/cc @chradek