Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency package lru-cache has a new version available #20363

Closed
azure-sdk opened this issue Feb 14, 2022 · 1 comment · Fixed by #20733
Closed

Dependency package lru-cache has a new version available #20363

azure-sdk opened this issue Feb 14, 2022 · 1 comment · Fixed by #20733
Assignees
@deyaaeldeen
Labels
dependency-upgrade-required
Milestone
[2022] April

Comments

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 14, 2022 •
edited
Loading

We have identified a dependency on version 6.0.0 of lru-cache. A new version (7.4.1) is available for upgrade.

Following are the steps to upgrade package dependency.

  1. Understand the breaking changes between the version being used and the version you want to upgrade to.

  2. Identify all packages that take a dependency on this package.

  3. Go to the root folder for each such package (/sdk/service-name/package-name) and update package.json to have the new version.

  4. Run rush update to ensure the new version is pulled in.

  5. Make relevant changes to absorb the breaking changes.

  6. Repeat steps 3 to 5 for each of the packages that have a dependency on this package.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 14, 2022
@azure-sdk
Copy link
Collaborator Author

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.31037417,Service Bus:0.14600384,Azure.Identity:0.05549664'

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Schema Registry labels Feb 14, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 14, 2022
@ramya-rao-a ramya-rao-a added this to the [2022] April milestone Feb 14, 2022
@azure-sdk azure-sdk removed Client This issue points to a problem in the data-plane of the library. Schema Registry labels Feb 28, 2022
@deyaaeldeen deyaaeldeen mentioned this issue Mar 9, 2022
Merged
3 tasks
deyaaeldeen added a commit that referenced this issue Mar 9, 2022
@deyaaeldeen
[Schema Registry Avro] Log cache size (#20733)
69e4dd9 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes #20245
Fixes #20363
Fixes #20565

### Describe the problem that is addressed by this PR
Logging cache size so customers understands how it grows in their application

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The proposed approach logs the length of all stringified schemas which I believe is consistent with what .NET does.

What else could we log here that we should consider?


### Are there test cases added in this PR? _(If not, why?)_
N/A

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@deyaaeldeen @WeiJun428
[Schema Registry Avro] Log cache size (Azure#20733)
c812037 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes Azure#20245
Fixes Azure#20363
Fixes Azure#20565

### Describe the problem that is addressed by this PR
Logging cache size so customers understands how it grows in their application

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The proposed approach logs the length of all stringified schemas which I believe is consistent with what .NET does.

What else could we log here that we should consider?


### Are there test cases added in this PR? _(If not, why?)_
N/A

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@deyaaeldeen @WeiJun428
[Schema Registry Avro] Log cache size (Azure#20733)
210332c 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes Azure#20245
Fixes Azure#20363
Fixes Azure#20565

### Describe the problem that is addressed by this PR
Logging cache size so customers understands how it grows in their application

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The proposed approach logs the length of all stringified schemas which I believe is consistent with what .NET does.

What else could we log here that we should consider?


### Are there test cases added in this PR? _(If not, why?)_
N/A

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Nov 14, 2022
@prabhavgupta @prabgupta
@priyankajayaswal1 @msyyc
CodeGen from PR 20363 in Azure/azure-rest-api-specs
52835b0 
Users/prjayasw/agrifoodrp (Azure#20363)

* Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview

* Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* Private endpoint changes

* updated examples

* updated db update example

* build fixes

* changed common-types version

* pr comments

* minor update

* Removed 202 response code from Put call

* update examples

* prettier fix

* enum example fix

* Incremental change of sensor feature

* Adding support for operationResults api for farmbeats resource.

* Making cosmetic changes to fix checks

* Update readme.python.md

pin the title for python SDK

* Fixing one change

* Rsolving comments

* Updating Extension Create api and removing extension update api

* Removing ApiProperties from required list and adding Extension_CreateOrUpdate.json

* Adding examples/Extensions_Delete.json and removing examples/Extensions_Update.json. Also, adding few small changes to Extension apis

* Fixing a small typo

* Fixing failing checks

* Fixing example for extension create or update

* Fixing prettier error

Co-authored-by: Prabhav Gupta <[email protected]>
Co-authored-by: Prabhav Gupta <[email protected]>
Co-authored-by: Priyanka Jayaswal <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deyaaeldeen deyaaeldeen

Labels
dependency-upgrade-required
Projects
None yet
Milestone
[2022] April
Development

Successfully merging a pull request may close this issue.

[Schema Registry Avro] Log cache size deyaaeldeen/azure-sdk-for-js
3 participants
@deyaaeldeen @ramya-rao-a @azure-sdk