Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Avro Encoder] Add logging of cache size #20245

Closed
JoshLove-msft opened this issue Feb 8, 2022 · 0 comments · Fixed by #20733
Closed

[Avro Encoder] Add logging of cache size #20245

JoshLove-msft opened this issue Feb 8, 2022 · 0 comments · Fixed by #20733
Assignees
@deyaaeldeen
Labels
Client This issue points to a problem in the data-plane of the library. Schema Registry
Milestone
[2022] March

Comments

@JoshLove-msft
Copy link
Member

As we discussed in the arch board review, we should log the size of the cache whenever a new entry is added.
@JoshLove-msft JoshLove-msft added Client This issue points to a problem in the data-plane of the library. Schema Registry labels Feb 8, 2022
@ramya-rao-a ramya-rao-a added this to the [2022] March milestone Feb 8, 2022
This was referenced Mar 3, 2022
Closed
Merged
deyaaeldeen added a commit that referenced this issue Mar 9, 2022
@deyaaeldeen
[Schema Registry Avro] Log cache size (#20733)
69e4dd9 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes #20245
Fixes #20363
Fixes #20565

### Describe the problem that is addressed by this PR
Logging cache size so customers understands how it grows in their application

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The proposed approach logs the length of all stringified schemas which I believe is consistent with what .NET does.

What else could we log here that we should consider?


### Are there test cases added in this PR? _(If not, why?)_
N/A

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@deyaaeldeen @WeiJun428
[Schema Registry Avro] Log cache size (Azure#20733)
c812037 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes Azure#20245
Fixes Azure#20363
Fixes Azure#20565

### Describe the problem that is addressed by this PR
Logging cache size so customers understands how it grows in their application

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The proposed approach logs the length of all stringified schemas which I believe is consistent with what .NET does.

What else could we log here that we should consider?


### Are there test cases added in this PR? _(If not, why?)_
N/A

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@deyaaeldeen @WeiJun428
[Schema Registry Avro] Log cache size (Azure#20733)
210332c 
### Packages impacted by this PR
@azure/schema-registry-avro

### Issues associated with this PR
Fixes Azure#20245
Fixes Azure#20363
Fixes Azure#20565

### Describe the problem that is addressed by this PR
Logging cache size so customers understands how it grows in their application

### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
The proposed approach logs the length of all stringified schemas which I believe is consistent with what .NET does.

What else could we log here that we should consider?


### Are there test cases added in this PR? _(If not, why?)_
N/A

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_
- [ ] Added a changelog (if necessary)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deyaaeldeen deyaaeldeen

Labels
Client This issue points to a problem in the data-plane of the library. Schema Registry
Projects
None yet
Milestone
[2022] March
Development

Successfully merging a pull request may close this issue.

[Schema Registry Avro] Log cache size deyaaeldeen/azure-sdk-for-js
3 participants
@deyaaeldeen @ramya-rao-a @JoshLove-msft