Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Some test organization improvements #10796

Closed
sadasant opened this issue Aug 24, 2020 · 3 comments
Closed

[Storage] Some test organization improvements #10796

sadasant opened this issue Aug 24, 2020 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) test-enhancement

Comments

@sadasant
Copy link
Contributor

sadasant commented Aug 24, 2020

Hi team! I'm making this issue at least as a discussion point on some improvements I believe we could make in the storage tests.

Specifically:

- To separate tests into internal and public, which is nowadays necessary to implement min-max testing. Covered in #9446

  • To group the soft-delete tests into their own describe blocks and to skip the whole block instead of skipping test by test. This will make these tests more readable for users. I believe. (In reference to: this, for example)

Feel free to make new issues and to close this, but please consider this feedback first.

@sadasant sadasant added the Storage Storage Service (Queues, Blobs, Files) label Aug 24, 2020
@sadasant sadasant added this to the Backlog milestone Aug 24, 2020
@ljian3377 ljian3377 added test enhancement Client This issue points to a problem in the data-plane of the library. labels Oct 21, 2020
@ljian3377 ljian3377 self-assigned this Oct 21, 2020
@ljian3377
Copy link
Member

@XiaoningLiu @jiacfan for awareness.

@ramya-rao-a
Copy link
Contributor

Updated issue description to scope this issue to the suggestion around the soft-delete tests. Will re-open #9446 for the internal vs public folder and enabling of the min/max testing

Copy link

Hi @sadasant, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) test-enhancement
Projects
None yet
Development

No branches or pull requests

5 participants