Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage] Separation of internal and public tests into separate folders #9446

Closed
4 tasks
KarishmaGhiya opened this issue Jun 10, 2020 · 4 comments
Closed
4 tasks
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) test-enhancement

Comments

@KarishmaGhiya
Copy link
Member

KarishmaGhiya commented Jun 10, 2020

  • Packages -

  • "@azure/storage-blob",

  • "@azure/storage-file-share",

  • "@azure/storage-file-datalake",

  • "@azure/storage-queue"

  • Min-max dependency testing needs to be enabled on all packages and it works on public APIs.

  • The test/public folder should contain usage of ONLY the public exported APIs

  • Careful and manual code separaton of these tests need to be done

  • Example of folder separation done on keyvault-secrets - https://github.com/Azure/azure-sdk-for-js/pull/9211/files

we also need enable min-max testing by removing the filter from their pipeline

     MatrixFilters:
        - DependencyVersion=^$ 
@KarishmaGhiya KarishmaGhiya added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jun 10, 2020
@ghost
Copy link

ghost commented Jun 10, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jun 10, 2020
@ljian3377
Copy link
Member

Closing this in favor of #10796.

@ramya-rao-a
Copy link
Contributor

Re-opening as the scope in #10796 has been reduced for easier issue management

Copy link

Hi @KarishmaGhiya, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) test-enhancement
Projects
None yet
Development

No branches or pull requests

5 participants