[Storage] Add support for share soft delete. #10792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacfan
requested review from
HarshaNalluru,
jeremymeng,
ljian3377,
vinjiang and
XiaoningLiu
as code owners
ghost
added
the
jiacfan
changed the title
jiacfan
added
the
Client
|
Do we have any API changes? Need to re-generate the review file with |
|
Extracted API for review. In reply to: 678980593 [](ancestors = 678980593) |
sadasant
reviewed
Aug 24, 2020
sadasant
reviewed
Aug 24, 2020
sadasant
reviewed
Aug 24, 2020
sadasant
reviewed
Aug 24, 2020
bterlson
approved these changes
Aug 24, 2020
|
LGTM. Agree with @sadasant on grouping the test cases as they have same logic for skipping. #Resolved |
ljian3377
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added share soft delete support. Added
undeleteSharetoShareServiceClient.listSharesnow can return deleted shares. Note: share soft delete only take effect on accounts with share soft delete feature enabled.For design, as align to .Net and Java,
undeleteShareis added underShareServiceClient, while not involvingundeleteunder 'ShareClient'. This is due toundeletedoesn't support restore deleted share to a different share name in service side yet.