[eslint-plugin-azure-sdk] Replaced redundant custom rule ts-no-namesp…

…aces with typescript-eslint/no-namespace (#18676) * Removed ts-no-namespaces and replaced with typescript-eslint/no-namespace * Fixed README.md Co-authored-by: bbrusniak <[email protected]>
Azure · Nov 22, 2021 · 65e171e · 65e171e
1 parent 53ef842
commit 65e171e
Show file tree

Hide file tree

Showing 14 changed files with 10 additions and 113 deletions.
diff --git a/common/tools/eslint-plugin-azure-sdk/README.md b/common/tools/eslint-plugin-azure-sdk/README.md
@@ -113,7 +113,6 @@ Some rules (see table below) are fixable using the `--fix` ESLint option (added
 | [**ts-naming-subclients**](https://github.com/Azure/azure-sdk-for-js/blob/main/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-naming-subclients.md)                                             | :triangular_flag_on_post: | :x:                | `1.2.0` |
 | [**ts-no-const-enums**](https://github.com/Azure/azure-sdk-for-js/blob/main/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-no-const-enums.md)                                                   | :warning:                 | :heavy_check_mark: | `1.1.0` |
 | [**ts-no-window**](https://github.com/Azure/azure-sdk-for-js/blob/main/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-no-window.md)                                                             | :triangular_flag_on_post: | :heavy_check_mark: | `3.1.0` |
-| [**ts-no-namespaces**](https://github.com/Azure/azure-sdk-for-js/blob/main/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-no-namespaces.md)                                                     | :triangular_flag_on_post: | :x:                | `1.2.0` |
 | [**ts-package-json-author**](https://github.com/Azure/azure-sdk-for-js/blob/main/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-author.md)                                         | :triangular_flag_on_post: | :heavy_check_mark: | `1.0.0` |
 | [**ts-package-json-bugs**](https://github.com/Azure/azure-sdk-for-js/blob/main/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-bugs.md)                                             | :triangular_flag_on_post: | :heavy_check_mark: | `1.0.0` |
 | [**ts-package-json-engine-is-present**](https://github.com/Azure/azure-sdk-for-js/blob/main/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-engine-is-present.md)                   | :triangular_flag_on_post: | :heavy_check_mark: | `1.1.0` |

diff --git a/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-no-namespaces.md b/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-no-namespaces.md
diff --git a/common/tools/eslint-plugin-azure-sdk/src/configs/azure-sdk-base.ts b/common/tools/eslint-plugin-azure-sdk/src/configs/azure-sdk-base.ts
@@ -88,7 +88,7 @@ export default {
     "@typescript-eslint/no-inferrable-types": "off",
     // We use empty extends and empty interface for shimming and renaming extensively
     "@typescript-eslint/no-empty-interface": "off",
-    "@typescript-eslint/no-namespace": "off",
+    "@typescript-eslint/no-namespace": "error",
     "@typescript-eslint/no-non-null-assertion": "off",
     "@typescript-eslint/no-unused-vars": ["warn", { argsIgnorePattern: "^_" }],
     "@typescript-eslint/no-useless-constructor": "error",

diff --git a/common/tools/eslint-plugin-azure-sdk/src/configs/index.ts b/common/tools/eslint-plugin-azure-sdk/src/configs/index.ts
@@ -47,7 +47,6 @@ export = {
       "@azure/azure-sdk/ts-naming-options": "error",
       "@azure/azure-sdk/ts-naming-subclients": "error",
       "@azure/azure-sdk/ts-no-const-enums": "warn",
-      "@azure/azure-sdk/ts-no-namespaces": "error",
       "@azure/azure-sdk/ts-no-window": "error",
       "@azure/azure-sdk/ts-package-json-author": "error",
       "@azure/azure-sdk/ts-package-json-bugs": "error",

diff --git a/common/tools/eslint-plugin-azure-sdk/src/rules/index.ts b/common/tools/eslint-plugin-azure-sdk/src/rules/index.ts
@@ -31,7 +31,6 @@ import tsNamingDropNoun from "./ts-naming-drop-noun";
 import tsNamingOptions from "./ts-naming-options";
 import tsNamingSubclients from "./ts-naming-subclients";
 import tsNoConstEnums from "./ts-no-const-enums";
-import tsNoNamespaces from "./ts-no-namespaces";
 import tsNoWindow from "./ts-no-window";
 import tsPackageJsonAuthor from "./ts-package-json-author";
 import tsPackageJsonBugs from "./ts-package-json-bugs";
@@ -82,7 +81,6 @@ export = {
   "ts-naming-options": tsNamingOptions,
   "ts-naming-subclients": tsNamingSubclients,
   "ts-no-const-enums": tsNoConstEnums,
-  "ts-no-namespaces": tsNoNamespaces,
   "ts-no-window": tsNoWindow,
   "ts-package-json-author": tsPackageJsonAuthor,
   "ts-package-json-bugs": tsPackageJsonBugs,

diff --git a/common/tools/eslint-plugin-azure-sdk/src/rules/ts-no-namespaces.ts b/common/tools/eslint-plugin-azure-sdk/src/rules/ts-no-namespaces.ts
diff --git a/common/tools/eslint-plugin-azure-sdk/tests/rules/ts-no-namespaces.ts b/common/tools/eslint-plugin-azure-sdk/tests/rules/ts-no-namespaces.ts
diff --git a/sdk/attestation/attestation/src/jsrsasign.d.ts b/sdk/attestation/attestation/src/jsrsasign.d.ts
@@ -1,5 +1,5 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-// eslint-disable-next-line @azure/azure-sdk/ts-no-namespaces
+// eslint-disable-next-line @typescript-eslint/no-namespace
 declare module 'jsrsasign';
diff --git a/sdk/containerregistry/container-registry/src/utils/base64.browser.ts b/sdk/containerregistry/container-registry/src/utils/base64.browser.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-// eslint-disable-next-line @azure/azure-sdk/ts-no-namespaces
+// eslint-disable-next-line @typescript-eslint/no-namespace
 declare global {
   function atob(input: string): string;
 }

diff --git a/sdk/core/core-client/src/base64.browser.ts b/sdk/core/core-client/src/base64.browser.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-// eslint-disable-next-line @azure/azure-sdk/ts-no-namespaces
+// eslint-disable-next-line @typescript-eslint/no-namespace
 declare global {
   // stub these out for the browser
   function btoa(input: string): string;

diff --git a/sdk/core/core-http/src/httpOperationResponse.ts b/sdk/core/core-http/src/httpOperationResponse.ts
@@ -24,7 +24,7 @@ export interface HttpResponse {
   headers: HttpHeadersLike;
 }
 
-// eslint-disable-next-line @azure/azure-sdk/ts-no-namespaces
+// eslint-disable-next-line @typescript-eslint/no-namespace
 declare global {
   /**
    * Stub declaration of the browser-only Blob type.

diff --git a/sdk/core/core-lro/test/utils/router/paramRoutes.ts b/sdk/core/core-lro/test/utils/router/paramRoutes.ts
@@ -224,7 +224,7 @@ function deleteasyncRetry(request: PipelineRequest): PipelineResponse | undefine
   return undefined;
 }
 
-// eslint-disable-next-line @azure/azure-sdk/ts-no-namespaces
+// eslint-disable-next-line @typescript-eslint/no-namespace
 namespace deleteasyncRetry {
   export let internalCounter: number = 1; // eslint-disable-line prefer-const
 }
@@ -293,7 +293,7 @@ function putasyncRetry(request: PipelineRequest): PipelineResponse | undefined {
   return undefined;
 }
 
-// eslint-disable-next-line @azure/azure-sdk/ts-no-namespaces
+// eslint-disable-next-line @typescript-eslint/no-namespace
 namespace putasyncRetry {
   export let internalCounter: number = 1; // eslint-disable-line prefer-const
 }
@@ -369,7 +369,7 @@ function postasyncRetry(request: PipelineRequest): PipelineResponse | undefined
   return undefined;
 }
 
-// eslint-disable-next-line @azure/azure-sdk/ts-no-namespaces
+// eslint-disable-next-line @typescript-eslint/no-namespace
 namespace postasyncRetry {
   export let internalCounter: number = 1; // eslint-disable-line prefer-const
 }

diff --git a/sdk/eventhub/event-hubs/src/connectionContext.ts b/sdk/eventhub/event-hubs/src/connectionContext.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-/* eslint-disable @azure/azure-sdk/ts-no-namespaces */
+/* eslint-disable @typescript-eslint/no-namespace */
 /* eslint-disable no-inner-declarations */
 
 import { logger, logErrorStackTrace } from "./log";

diff --git a/sdk/identity/identity/test/internal/node/interactiveBrowserCredential.spec.ts b/sdk/identity/identity/test/internal/node/interactiveBrowserCredential.spec.ts
@@ -2,7 +2,7 @@
 // Licensed under the MIT license.
 
 /* eslint-disable @typescript-eslint/no-non-null-asserted-optional-chain */
-/* eslint-disable @azure/azure-sdk/ts-no-namespaces */
+/* eslint-disable @typescript-eslint/no-namespace */
 
 import Sinon from "sinon";
 import { assert } from "chai";