Skip to content

Commit

Permalink
[eslint] - fix plugin rule list (#18771)
Browse files Browse the repository at this point in the history
It looks like ts-package-json-sdktype rule entry was duplicated in #18597 -
which causes the "number of rules should match the expected value" to report an
error.

This PR fixes the issue by removing the duplicated entry. I also went ahead and
sorted the entries to make these things easier to spot in the future (although
there is no guarantee sort will be preserved).
  • Loading branch information
maorleger authored Nov 22, 2021
1 parent f62fae1 commit 53ef842
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/src/rules/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export = {
"ts-no-namespaces": tsNoNamespaces,
"ts-no-window": tsNoWindow,
"ts-package-json-author": tsPackageJsonAuthor,
"ts-package-json-sdktype": tsPackageJsonSdkType,
"ts-package-json-bugs": tsPackageJsonBugs,
"ts-package-json-engine-is-present": tsPackageJsonEngineIsPresent,
"ts-package-json-files-required": tsPackageJsonFilesRequired,
Expand All @@ -97,6 +96,7 @@ export = {
"ts-package-json-name": tsPackageJsonName,
"ts-package-json-repo": tsPackageJsonRepo,
"ts-package-json-required-scripts": tsPackageJsonRequiredScripts,
"ts-package-json-sdktype": tsPackageJsonSdkType,
"ts-package-json-sideeffects": tsPackageJsonSideEffects,
"ts-package-json-types": tsPackageJsonTypes,
"ts-pagination-list": tsPaginationList,
Expand Down
1 change: 0 additions & 1 deletion common/tools/eslint-plugin-azure-sdk/tests/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ const ruleList = [
"ts-no-namespaces",
"ts-no-window",
"ts-package-json-author",
"ts-package-json-sdktype",
"ts-package-json-bugs",
"ts-package-json-engine-is-present",
"ts-package-json-files-required",
Expand Down

0 comments on commit 53ef842

Please sign in to comment.