Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding default rule support for subscription creation #31804

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Adding default rule support for subscription creation #31804

merged 6 commits into from
Oct 31, 2022

Conversation

ki1729
Copy link
Contributor

@ki1729 ki1729 commented Oct 28, 2022 •
edited
Loading

Description

  • Adding default rule support to subscriptions. Today there is a gap from when a subscription is created , to when correct rules are configured when incorrect messages can get through. This addresses that gap.
  • This also fixes the issue of missing tests for sync admin client which caused a hotfix release. (Added Sync AdminClientIntegrationTests).

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Service Bus label Oct 28, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-messaging-servicebus

@ki1729 ki1729 mentioned this pull request Oct 31, 2022
Closed
@ki1729 ki1729 enabled auto-merge (squash) October 31, 2022 18:57
@ki1729 ki1729 requested review from conniey and anuchandy October 31, 2022 19:47
anuchandy
anuchandy approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ki1729 ki1729 merged commit 18b160b into Azure:main Oct 31, 2022
This was referenced Nov 1, 2022
Closed
Closed
@ki1729 ki1729 mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

@liukun-msft liukun-msft Awaiting requested review from liukun-msft

@ZejiaJiang ZejiaJiang Awaiting requested review from ZejiaJiang

@conniey conniey Awaiting requested review from conniey conniey is a code owner

Assignees
No one assigned
Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ki1729 @azure-sdk @anuchandy @conniey