Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] ATOM API Allow configuring "rule" while creating subscription #17384

Closed
HarshaNalluru opened this issue Nov 9, 2020 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Milestone

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Nov 9, 2020

.NET SDK provides CreateSubscription overload which allows configuring the rule.

public virtual Task<Response<SubscriptionProperties>> CreateSubscriptionAsync(CreateSubscriptionOptions options, CancellationToken cancellationToken = default);
public virtual Task<Response<SubscriptionProperties>> CreateSubscriptionAsync(CreateSubscriptionOptions options, CreateRuleOptions rule, CancellationToken cancellationToken = default);

This issue is to track adding support for the same in Java V7 SDK.
This feature is important because..
While creating a new subscription to an active topic(messages are actively being sent), there is no way users can stop filling up the subscription before the rule filter is added(since the default rule filter is TRUE).

Original issue: Azure/azure-sdk-for-js#12345

@YijunXieMS @hemanttanwar @conniey @ramya-rao-a

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 9, 2020
@conniey conniey added Client This issue points to a problem in the data-plane of the library. Service Bus labels Nov 9, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 9, 2020
@conniey conniey added this to the [2020] December milestone Nov 9, 2020
@ramya-rao-a
Copy link
Contributor

Moving the milestone to Backlog as this can be added in the next semester as well. Please feel free to add details on how to approach this task and add the "help wanted" label

@ramya-rao-a ramya-rao-a modified the milestones: [2020] December, Backlog Nov 9, 2020
@ramya-rao-a
Copy link
Contributor

@ki1729 Can you please add instructions on how someone can contribute to this feature request?

@ramya-rao-a ramya-rao-a added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Aug 25, 2021
@ki1729 ki1729 self-assigned this Apr 11, 2022
@ki1729 ki1729 removed the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Apr 11, 2022
@ki1729 ki1729 modified the milestones: Backlog, [2022] May Apr 11, 2022
@anuchandy anuchandy changed the title [Service Bus] ATOM API: Allow configuring "rule" while creating subscription [FEATURE REQ] ATOM API Allow configuring "rule" while creating subscription Apr 26, 2022
@conniey conniey added the feature-request This issue requires a new behavior in the product in order be resolved. label Apr 26, 2022
@ki1729 ki1729 modified the milestones: [2022] May, [2022] June May 9, 2022
@conniey conniey modified the milestones: 2022-06, 2022-08 Jun 29, 2022
@ki1729
Copy link
Contributor

ki1729 commented Oct 31, 2022

Feature out for review: #31804

@ki1729
Copy link
Contributor

ki1729 commented Oct 31, 2022

This is now merged and will be released as part of SDK version 7.13.0

@ki1729 ki1729 closed this as completed Oct 31, 2022
Repository owner moved this from Planned to Done in Azure SDK for Service Bus Oct 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Projects
Status: Done
Development

No branches or pull requests

4 participants