Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify sources of Kafka binder context for Azure Identity support #30251

Closed

Conversation

yiliuTo
Copy link
Member

@yiliuTo yiliuTo commented Aug 3, 2022

Description

Resolves #29976. Using a BeanPostProcessor to override the spring.main.sources of Kafka binder's properties.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

yiliuTo and others added 7 commits August 2, 2022 12:56
* first commit for patch release

* patch pipeline files

* Remove ServiceDirectory template parameter

* fix artifact variable in inline yml script

* comment out release yml template usage until it has been written

* change job name to Analyze and Verify, removing the special character yml doesn't like

* Remove spaces from job names

* Remove a couple of unnecessary step conditions

* Update client-patch yml for set-test-pipeline-version updates

* move verify samples above verify readme for a test

* additional servicedirectories environment variables

* Install reporting tools before building from source

* Update build/verify and add release contents

* remove duplicate parameter

* call patch release not batch release

* Updates for review feedback

* plumb AdditionalBuildOptions through the yml files, the same as AdditionalLintingOptions
…30230)

* Added retries to tests that rely on slow-ish service response

* Removed retries from the client options tests

* Removed redundant retry options
@ghost ghost added the azure-spring All azure-spring related issues label Aug 3, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure

@yiliuTo yiliuTo closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants