Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Enhance AzureKafkaSpringCloudStreamConfiguration to Kafka Binder's source configuration #29976

Closed
1 of 2 tasks
Tracked by #28685
yiliuTo opened this issue Jul 15, 2022 · 3 comments
Closed
1 of 2 tasks
Tracked by #28685

[FEATURE REQ] Enhance AzureKafkaSpringCloudStreamConfiguration to Kafka Binder's source configuration #29976

yiliuTo opened this issue Jul 15, 2022 · 3 comments
Assignees
@yiliuTo
Labels
azure-spring All azure-spring related issues azure-spring-4.0 azure-spring-docs azure-spring-eventhubs-kafka Spring event hubs kafka related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
2022-10

Comments

@yiliuTo
Copy link
Member

yiliuTo commented Jul 15, 2022 •
edited
Loading

Context

Currently the Azure Identity support of Spring Cloud Stream Kafka binder on Event Hubs requires developers to configure the property of spring.main.source for each Kafka binder with the value as our com.azure.spring.cloud.autoconfigure.kafka.AzureKafkaSpringCloudStreamConfiguration.

Goal

Given the value is fixed and it's always required, we should make it hard-coded in our library. In this way can help developers optimise their configuration with less properties.

Solution
@yiliuTo yiliuTo added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. azure-spring All azure-spring related issues azure-spring-eventhubs-kafka Spring event hubs kafka related issues. azure-spring-copper azure-spring-4.0 labels Jul 15, 2022
@yiliuTo yiliuTo added this to the 2022-08 milestone Jul 15, 2022
@yiliuTo yiliuTo self-assigned this Jul 15, 2022
@yiliuTo yiliuTo moved this to Todo in Spring Cloud Azure Jul 15, 2022
@yiliuTo yiliuTo mentioned this issue Jul 15, 2022
Closed
9 tasks
@yiliuTo yiliuTo moved this from Todo to In Progress in Spring Cloud Azure Aug 3, 2022
This was referenced Aug 3, 2022
Closed
Merged
@yiliuTo
Copy link
Member Author

yiliuTo commented Aug 4, 2022

Done in #30254

@yiliuTo yiliuTo closed this as completed Aug 4, 2022
Repository owner moved this from In Progress to Done in Spring Cloud Azure Aug 4, 2022
@yiliuTo
Copy link
Member Author

yiliuTo commented Aug 4, 2022

Reopen since the docs haven't been updated

@yiliuTo yiliuTo reopened this Aug 4, 2022
Repository owner moved this from Done to In Progress in Spring Cloud Azure Aug 4, 2022
@yiliuTo yiliuTo modified the milestones: 2022-08, 2022-09 Aug 9, 2022
@yiliuTo yiliuTo moved this from In Progress to Pending Review in Spring Cloud Azure Aug 9, 2022
@moarychan moarychan assigned hui1110 and unassigned yiliuTo Aug 9, 2022
@yiliuTo yiliuTo assigned yiliuTo and unassigned hui1110 Aug 9, 2022
@saragluna saragluna modified the milestones: 2022-09, 2022-10 Sep 6, 2022
@yiliuTo
Copy link
Member Author

yiliuTo commented Sep 6, 2022

Close this issue since the pr to update the doc has been created and pending for review/merge.

@yiliuTo yiliuTo closed this as completed Sep 6, 2022
Repository owner moved this from Pending Review to Done in Spring Cloud Azure Sep 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yiliuTo yiliuTo

Labels
azure-spring All azure-spring related issues azure-spring-4.0 azure-spring-docs azure-spring-eventhubs-kafka Spring event hubs kafka related issues. Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Archived in project
Milestone
2022-10
Development

No branches or pull requests
3 participants
@saragluna @hui1110 @yiliuTo