Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to specify client telemetry proxy with credentials #29197

Conversation

FabianMeiswinkel
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel commented Jun 2, 2022

Description

Fix issue: #29023. Customer would like to ONLY enable proxy for their clientTelemetry requests. But currently, clientTelemetryRequests and gatewayRequests are sharing the same HttpClient which makes it impossible. IN PR #29022 we separated the httpclients and allowed customer to config the proxy through System property.
This PR adds the option to also specify proxy credentials.

Example code:

 System.setProperty(
                        "COSMOS.CLIENT_TELEMETRY_PROXY_OPTIONS_CONFIG",
                       "{\"type\":\"HTTP\", \"host\": \"localhost\", \"port\": 8080, \"username\": \"SomeUser\", \"password\": \"SomeSecret\"}");

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants