-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow proxy for client telemetry #29022
Allow proxy for client telemetry #29022
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientTelemetryConfig.java
Outdated
Show resolved
Hide resolved
Good point, The name should definitely change then. ClientTelemetryConnectionConfig -> ClientTelemetryConfig |
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ClientTelemetryConnectionConfig.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ClientTelemetryConnectionConfig.java
Outdated
Show resolved
Hide resolved
/azp run java - cosmos |
Azure Pipelines successfully started running 1 pipeline(s). |
...osmos/src/test/java/com/azure/cosmos/implementation/GoneAndRetryPolicyWithSpyClientTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - except for the test comment (please revert all the places where you use withClientTelemetryEnabled(false) - this is the default - those changes shouldn't be necessary.
/azp run java - cosmos |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientBuilder.java
Show resolved
Hide resolved
...cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientTelemetryConfig.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Configs.java
Show resolved
Hide resolved
/azp run java - cosmos |
Azure Pipelines successfully started running 1 pipeline(s). |
* update comments * allowClientTelemetryRequestToGoThroughProxy * resolve feedback * clear * update changelog * fix tests * fix spotbug issue * fix tests * resolve comments * resolve comments * add the tests change back * resolve comments Co-authored-by: annie-mac <[email protected]> Co-authored-by: annie-mac <[email protected]>
Description
Fix issue: #29023. Customer would like to ONLY enable proxy for their clientTelemetry requests. But currently, clientTelemetryRequests and gatewayRequests are sharing the same HttpClient which makes it impossible. So in this PR, internally we separate the httpclients and allow customer to config the proxy through System property.
Example code:
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines