Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete jacoco setting in spring modules #26187

Merged
merged 15 commits into from
Jan 11, 2022
Merged

Delete jacoco setting in spring modules #26187

merged 15 commits into from
Jan 11, 2022

Conversation

chenrujun
Copy link

As title.
Resolve #26175

@ghost ghost added the azure-spring All azure-spring related issues label Dec 27, 2021
@chenrujun chenrujun self-assigned this Dec 27, 2021
@chenrujun chenrujun added the Client This issue points to a problem in the data-plane of the library. label Dec 27, 2021
@chenrujun chenrujun added this to the [2022] February milestone Dec 27, 2021
@chenrujun chenrujun linked an issue Dec 27, 2021 that may be closed by this pull request
Use default jacoco setting for all spring-cloud-azure modules #26175
Closed
20 tasks
@chenrujun chenrujun changed the title gh-26175 Delete jacoco setting in spring modules. Delete jacoco setting in spring modules Dec 27, 2021
saragluna
saragluna approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna saragluna mentioned this pull request Jan 6, 2022
Closed
@rujche
Merge pull request #3 from moarychan/moary/fix-jacoco-converage-not-met
7f71fb2 
Add UTs for default Jacoco coverage threshold
@check-enforcer
Copy link

check-enforcer bot commented Jan 6, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@saragluna saragluna mentioned this pull request Jan 6, 2022
Closed
@chenrujun chenrujun assigned Netyyyy and unassigned chenrujun Jan 6, 2022
@chenrujun
Copy link
Author

Hi, @moarychan , could you please help to fix the pipeline failure?

yiliuTo
yiliuTo reviewed Jan 7, 2022
View reviewed changes
.../com/azure/spring/integration/eventhubs/inbound/health/EventHusProcessorInstrumentation.java Outdated
private final Duration noneErrorWindow;

private ErrorContext errorContext;
public class EventHusProcessorInstrumentation extends AbstractProcessorInstrumentation<ErrorContext> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo here: EventHubsProcessorInstrumentation instead of EventHusProcessorInstrumentation

...java/com/azure/spring/integration/eventhubs/inbound/EventHubsInboundChannelAdapterTests.java Outdated Show resolved Hide resolved
...main/java/com/azure/spring/integration/eventhubs/inbound/EventHubsInboundChannelAdapter.java Show resolved Hide resolved
...azure/spring/integration/eventhubs/inbound/health/EventHusProcessorInstrumentationTests.java

import java.time.Duration;

class EventHusProcessorInstrumentationTests extends AbstractProcessorInstrumentationTests<ErrorContext> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same typo

@Netyyyy
Copy link
Member

Netyyyy commented Jan 10, 2022

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo yiliuTo merged commit ef598a1 into Azure:feature/azure-spring-cloud-4.0 Jan 11, 2022
This was referenced Jan 11, 2022
Closed
Closed
Closed
@chenrujun chenrujun deleted the issue-26175-delete-jacoco-settings-in-spring-modules branch February 7, 2022 06:34
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Nov 2, 2023
@dishantmunjal @chandrasekarendran
@soumyapattnaik @nickpacificomsft @asmitt
CodeGen from PR 25967 in Azure/azure-rest-api-specs
254267b 
[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2023-08-01-preview (Azure#25967)

* Adds base for updating Microsoft.DataProtection from version preview/2023-06-01-preview to version 2023-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Re-Validate API Swagger Changes

* JobCancel & Job InProgress changes

* vault tier changes aks (Azure#25972)

* Add is isPartialRP boolean to AzureBackupDiscreteRecoveryPoint and examples (Azure#25974)

* Add is ispartialrp to AzureBackupDiscreteRecoveryPoint and examples

* Fix prettier issues in examples

* Including ValidateForModifyBackupRequest Defn.

* resolved comments (Azure#26064)

* Revert IsPartialRP changes (Azure#26070)

* Using Restricted Pattern for Vault Name (Azure#26169)

* Handling Validation Errors (Azure#26186)

* removing 200 status code

* LintDiff fix - using common types error response (Azure#26187)

* whitespace handling

* Editing where clause

* Removing Where Condition

---------

Co-authored-by: Dishant Munjal <[email protected]>
Co-authored-by: chandrasekarendran <[email protected]>
Co-authored-by: soumyapattnaik <[email protected]>
Co-authored-by: nickpacificomsft <[email protected]>
Co-authored-by: asmitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiliuTo yiliuTo yiliuTo left review comments

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@stliu stliu Awaiting requested review from stliu

Assignees

@Netyyyy Netyyyy

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Status: Done
Milestone
Spring Cloud Azure 4.0 Beta3
Development

Successfully merging this pull request may close these issues.

Use default jacoco setting for all spring-cloud-azure modules
6 participants
@chenrujun @Netyyyy @saragluna @yiliuTo @rujche @moarychan