Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default jacoco setting for all spring-cloud-azure modules #26175

Closed
20 tasks done
Tracked by #27112
chenrujun opened this issue Dec 24, 2021 · 1 comment · Fixed by #26174 or #26187
Closed
20 tasks done
Tracked by #27112

Use default jacoco setting for all spring-cloud-azure modules #26175

chenrujun opened this issue Dec 24, 2021 · 1 comment · Fixed by #26174 or #26187
Assignees
@Netyyyy
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@chenrujun
Copy link

chenrujun commented Dec 24, 2021 •
edited
Loading

jacoco-maven-plugin

We should delete the following contents:

<jacoco.min.linecoverage>xxx</jacoco.min.linecoverage>
<jacoco.min.branchcoverage>xxx</jacoco.min.branchcoverage>

in these modules:

  • spring-cloud-azure-actuator
  • spring-cloud-azure-actuator-autoconfigure
  • spring-cloud-azure-autoconfigure
  • spring-cloud-azure-core
  • spring-cloud-azure-resourcemanager
  • spring-cloud-azure-service
  • spring-cloud-azure-stream-binder-eventhubs
  • spring-cloud-azure-stream-binder-eventhubs-core
  • spring-cloud-azure-stream-binder-servicebus
  • spring-cloud-azure-stream-binder-servicebus-core
  • spring-cloud-azure-stream-binder-test
  • spring-cloud-azure-trace-sleuth
  • spring-integration-azure-core
  • spring-integration-azure-eventhubs
  • spring-integration-azure-servicebus
  • spring-integration-azure-storage-queue
  • spring-messaging-azure
  • spring-messaging-azure-eventhubs
  • spring-messaging-azure-servicebus
  • spring-messaging-azure-storage-queue

Add more tests if pipeline failed after delete these contents.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 24, 2021
@chenrujun chenrujun self-assigned this Dec 24, 2021
@chenrujun chenrujun added azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. labels Dec 24, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 24, 2021
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Dec 24, 2021
@chenrujun chenrujun added this to the Spring Cloud Azure 4.0 GA milestone Dec 24, 2021
@chenrujun chenrujun linked a pull request Dec 24, 2021 that will close this issue
Delete jacoco setting for spring-cloud-azure modules #26174
Merged
chenrujun pushed a commit to chenrujun/azure-sdk-for-java that referenced this issue Dec 27, 2021
@rujche
Azuregh-26175 Delete jacoco setting in spring modules.
fd04da4
@chenrujun chenrujun mentioned this issue Dec 27, 2021
Merged
@chenrujun chenrujun linked a pull request Dec 27, 2021 that will close this issue
Delete jacoco setting in spring modules #26187
Merged
@saragluna saragluna assigned Netyyyy and unassigned chenrujun Jan 6, 2022
@saragluna saragluna changed the title Use default jacoco setting for all spring-cloud-azure modules Use default jacoco setting for all spring-cloud-azure modules @moary Jan 6, 2022
@Netyyyy Netyyyy moved this from Todo to In Progress in Spring Cloud Azure Jan 7, 2022
@saragluna saragluna moved this from In Progress to Done in Spring Cloud Azure Jan 11, 2022
@saragluna
Copy link
Member

Closed in #26187.

@saragluna saragluna changed the title Use default jacoco setting for all spring-cloud-azure modules @moary Use default jacoco setting for all spring-cloud-azure modules Feb 15, 2022
@saragluna saragluna mentioned this issue Feb 15, 2022
Closed
35 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Netyyyy Netyyyy

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta3
3 participants
@chenrujun @saragluna @Netyyyy