fix(issue#25182): eventhubs processor client start span independently #26157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am with opentelemetry is not enable
ghost
added
the
ZejiaJiang
changed the title
ZejiaJiang
changed the title
|
fix #25182 |
* add requirement.txt for python * use common mvn build * update readme if available
ZejiaJiang
requested review from
anuchandy,
conniey,
ki1729 and
srnagar
as code owners
…am with opentelemetry is not enable
…/azure-sdk-for-java into fix/eventhubs-telemetry-issue
ZejiaJiang
requested review from
alzimmermsft,
ArthurMa1978,
backwind1233,
benbp,
chenrujun and
g2vinay
as code owners
ZejiaJiang
requested review from
hallipr,
hui1110,
jialigit,
JonathanGiles,
joshfree,
mrm9084,
pallavit,
samvaity,
saragluna,
stliu,
vcolin7,
weshaggard,
XiaofeiCao and
yiliuTo
as code owners
samvaity
reviewed
Dec 27, 2021
| return Context.NONE; | ||
| } | ||
|
|
||
| Context spanContext = tracerProvider.extractContext(diagnosticId.toString(), Context.NONE) | ||
| Context spanContext = Objects.isNull(diagnosticId) ? Context.NONE : tracerProvider.extractContext(diagnosticId.toString(), Context.NONE); | ||
| spanContext = spanContext |
There was a problem hiding this comment.
Will this diagnosticId.toString() result in an NPE when diagnosticId is null?
There was a problem hiding this comment.
Will this
diagnosticId.toString()result in an NPE when diagnosticId is null?
the former code check diagnosticId before call the toStirng() method. The new code use Objects.IsNull() to check diagnosticId. BTW this PR is closed. And here is the new opened PR #26180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processor can start span if events come from upstream with opentelemetry is not enable
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines