Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to spring-cloud-dependencies:2021.0.0 #26124

Merged
merged 6 commits into from
Dec 23, 2021
Merged

Upgrade to spring-cloud-dependencies:2021.0.0 #26124

merged 6 commits into from
Dec 23, 2021

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Dec 20, 2021 •
edited
Loading

As title.
Related issue:#25581, it is compatible with Spring Boot: 2.6.1
Ref: https://spring.io/blog/2021/12/02/spring-cloud-2021-0-0-codename-jubilee-has-been-released

@ghost ghost added App Configuration Azure.ApplicationModel.Configuration azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 20, 2021
@ghost
Copy link

ghost commented Dec 20, 2021

Thank you for your contribution moarychan! We will review the pull request and get back to you soon.

@moarychan moarychan marked this pull request as draft December 20, 2021 10:02
chenrujun
chenrujun suggested changes Dec 20, 2021
View reviewed changes
sdk/spring/azure-spring-boot-starter-active-directory-b2c/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-identity-spring/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter-active-directory/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter-cosmos/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-core/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-eventhubs/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-servicebus/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-storage-queue/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-test/CHANGELOG.md Outdated Show resolved Hide resolved
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@Netyyyy
Copy link
Member

Netyyyy commented Dec 21, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@moarychan moarychan marked this pull request as ready for review December 21, 2021 08:22
chenrujun
chenrujun suggested changes Dec 22, 2021
View reviewed changes
sdk/spring/azure-spring-cloud-autoconfigure/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-context/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-messaging/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-starter-cache/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-cloud-starter-eventhubs-kafka/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-core/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-eventhubs/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-servicebus/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/spring/azure-spring-integration-storage-queue/CHANGELOG.md Show resolved Hide resolved
sdk/spring/azure-spring-integration-test/CHANGELOG.md Outdated Show resolved Hide resolved
chenrujun
chenrujun reviewed Dec 22, 2021
View reviewed changes
sdk/spring/azure-spring-cloud-stream-binder-test/CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
# Release History

## 2.12.0-beta.1 (Unreleased)
This release is compatible with Spring Boot 2.5.0-2.5.4, 2.6.0-2.6.1, and Spring Cloud 2021.0.0.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. This version does not support Spring Cloud 2020.0.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the modules that depend on this one?
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the three binders，using spring boot 2.5.7 spring cloud 2020.0.5 and spring boot 2.6.1 spring cloud 2021.0.0, they all work normally.

chenrujun
chenrujun approved these changes Dec 22, 2021
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

saragluna
saragluna requested changes Dec 23, 2021
View reviewed changes
sdk/spring/azure-spring-boot-starter-cosmos/CHANGELOG.md
@@ -1,6 +1,7 @@
# Release History

## 3.12.0-beta.1 (Unreleased)
This release is compatible with Spring Boot 2.5.5-2.5.8, 2.6.0-2.6.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the libraries are not working with the lower version of Spring Boot 2.5.x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to netty break change java.lang.NoSuchMethodError: io.netty.internal.tcnative.SSLContext.setCurvesList(J[Ljava/lang/String;)Z, eventhubs and cosmos sample will not work in Spring Boot 2.5.4 version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please offer more details here? Like EH or SB is using which netty version and such netty version is brought by which azure-core lib? And this SSLContext.setCurvesList(J[Ljava/lang/String;)Z is added in which netty version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIst the following dependencies according to the dependency of the error message:

  • azure-messaging-eventhubs:5.10.3 -> azure-core:1.22.0->netty-tcnative-boringssl-static:2.0.43.Final
  • spring booot 2.5.5 -> netty-tcnative:2.0.43.Final
  • spring booot 2.5.4 -> netty-tcnative:2.0.40.Final, currently found exception in Cosmos, Eventhusb samples

@Netyyyy
Copy link
Member

Netyyyy commented Dec 23, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yiliuTo yiliuTo merged commit 972aaa8 into Azure:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@chenrujun chenrujun chenrujun approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@mrm9084 mrm9084 Awaiting requested review from mrm9084

@pallavit pallavit Awaiting requested review from pallavit

@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@stliu stliu Awaiting requested review from stliu

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft weidongxu-microsoft is a code owner

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees
No one assigned
Labels
App Configuration Azure.ApplicationModel.Configuration azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moarychan @Netyyyy @chenrujun @saragluna @yiliuTo