Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service Bus] Add Dead Letter Queues Sample #22142

Merged
merged 11 commits into from
Jul 1, 2021
Merged

[Service Bus] Add Dead Letter Queues Sample #22142

merged 11 commits into from
Jul 1, 2021

Conversation

v-hongli1
Copy link
Member

@v-hongli1 v-hongli1 commented Jun 8, 2021 •
edited by conniey
Loading

  1. Fixes [Service Bus] Sample needed for Dead Letter Queues  #20452
  2. Add file:
    1. sdk/servicebus/azure-messaging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java

@jongio ,@ramya-rao-a for notification

@ghost ghost added Service Bus customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jun 8, 2021
@ghost
Copy link

ghost commented Jun 8, 2021

Thank you for your contribution hongli750210! We will review the pull request and get back to you soon.

@check-enforcer
Copy link

check-enforcer bot commented Jun 9, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@v-hongli1 v-hongli1 marked this pull request as ready for review June 9, 2021 08:04
@v-xuto v-xuto changed the title [Service Bus] Sample needed for Dead Letter Queues [Service Bus] Add Dead Letter Queues Sample Jun 9, 2021
YijunXieMS
YijunXieMS suggested changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@YijunXieMS YijunXieMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good examples with both deadlettering and receiving deadletterred messages!

sdk/servicebus/azure-messaging-servicebus/pom.xml Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
@conniey conniey self-assigned this Jun 28, 2021
conniey
conniey requested changes Jun 28, 2021
View reviewed changes
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
...saging-servicebus/src/samples/java/com/azure/messaging/servicebus/DeadletterQueueSample.java Outdated Show resolved Hide resolved
@v-hongli1 v-hongli1 requested a review from ki1729 as a code owner June 30, 2021 22:30
@conniey
Copy link
Member

conniey commented Jul 1, 2021

/check-enforcer override

@conniey conniey merged commit a410b47 into Azure:main Jul 1, 2021
@conniey conniey deleted the issue#20452 branch July 1, 2021 16:33
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Feb 2, 2023
CodeGen from PR 22154 in Azure/azure-rest-api-specs
7de498a 
Dev keyvault microsoft.key vault 2022 02 01 preview swagger completeness (Azure#22154)

* Adds base for updating Microsoft.KeyVault from version stable/2022-07-01 to version 2022-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* Fixed breaking changes in managedHsm.json. (Azure#22112)

Fixed LRO_RESPONSE_HEADER, INVALID_REQUEST_PARAMETER and OBJECT_MISSING_REQUIRED_PROPERTY errors.

Co-authored-by: Rahul Alapati <[email protected]>

* Undid the API version changes to the Vaults_List API (Azure#22142)

* Fixed breaking changes in managedHsm.json.
Fixed LRO_RESPONSE_HEADER, INVALID_REQUEST_PARAMETER and OBJECT_MISSING_REQUIRED_PROPERTY errors.

* Undid the API Version change to the VaultListFilterTypes API.

Co-authored-by: Rahul Alapati <[email protected]>

* Update listVault.json (Azure#22155)

* Update listVault.json

* Remove the preview API version for the enum

* Delete Vault_Lists API specification

* Added the Vaults_List swagger specification back.

* Abstracted Vaults_List API into 2015-11-01 directory to Swagger ModelValidation Errors.

* Resolved unresolvable references.

* Reorganized the definitions.

* Reorganized the 2015-11-01 directory under 2022-02-01-preview

* Moved the 2015-11-10 directory to stable.

* Undo the abstraction changes.

* Readd the listVault.json.

* Added suppression directives for INVALID_REQUEST_PARAMETER and OBJECT_MISSING_REQUIRED_PROPERTY.

* Modify suppress rule.

* Update the suppression directive.

* Update suppression directive.

* Update suppression directive.

* Update suppression directives.

* Updated suppression directive.

* Added suppression directives for INVALID_REQUEST_PARAMETER, OBJECT_MISSING_REQUIRED_PROPERTY

* Updated suppression directives.

* Updated suppression directives.

* Updated suppression directives.

* Updated suppression directives.

* Updated suppression directives.

* Added x-ms-validation rules to the api-version parameter.

* Updated suppression directives.

* Added individual suppression directives.

* Removed where clause from the OBJECT_MISSING_REQUIRED_PROPERTY suppression directive.

* Corrected yaml title for suppression directives.

Co-authored-by: Rahul Alapati <[email protected]>

---------

Co-authored-by: Rahul Alapati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy left review comments

@YijunXieMS YijunXieMS YijunXieMS approved these changes

@conniey conniey conniey approved these changes

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@yvgopal yvgopal Awaiting requested review from yvgopal

@ki1729 ki1729 Awaiting requested review from ki1729

Assignees

@conniey conniey

Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Service Bus] Sample needed for Dead Letter Queues
4 participants
@v-hongli1 @conniey @anuchandy @YijunXieMS