Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Sample needed for Dead Letter Queues #20452

Closed
ramya-rao-a opened this issue Apr 8, 2021 · 2 comments · Fixed by #22142
Closed

[Service Bus] Sample needed for Dead Letter Queues #20452

ramya-rao-a opened this issue Apr 8, 2021 · 2 comments · Fixed by #22142
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Docs Service Bus
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

The doc Overview of dead letter queues links to a sample that uses the older .NET package WindowsAzure.ServiceBus

Ideally, there should be links to samples that use packages from all languages. This issue is to add a corresponding sample that uses the azure-messaging-servicebus package so that it can be linked appropriately.

Reference: DeadletterQueue

Adding this sample will also be useful for us to re-direct readers who land at the above sample.

cc @spelluru

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 8, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Docs Service Bus labels Apr 8, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 8, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] May milestone Apr 8, 2021
@YijunXieMS YijunXieMS modified the milestones: [2021] May, [2021] June Apr 27, 2021
@v-hongli1
Copy link
Member

@ramya-rao-a - After investigation, I found that the DeadletterQueue sample about java already exists, but the package it uses is com-microsoft-azure-servicebus.
So I think there are two ways to change:

  1. Based on the original sample, update com-microsoft-azure-servicebus package to azure-messaging-servicebus package.
  2. Add a new DeadletterQueue sample using the azure-messaging-servicebus package, whose package directory is com.azure.servicebus.samples.deadletterqueue

Which one do you think is more appropriate? If you have better suggestions, please tell me, thanks!

@ramya-rao-a
Copy link
Contributor Author

We need a copy of the Java DeadletterQueue sample you found that uses the newer package azure-messaging-servicebus. This should live in https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/servicebus/azure-messaging-servicebus/src/samples

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Sep 21, 2022
Add privacy verbiage to 2022-07-01 API (Azure#20452)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Docs Service Bus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants