Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Reflection to Configure Jackson 2.12 Features (#19918) #19967

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Use Reflection to Configure Jackson 2.12 Features (#19918) #19967

merged 1 commit into from
Mar 19, 2021

Conversation

alzimmermsft
Copy link
Member

Use MethodHandles when using Jackson 2.12 Features to Prevent Errors when Jackson 2.11 is Resolved

@alzimmermsft
Use Reflection to Configure Jackson 2.12 Features (Azure#19918)
f931800 
Use MethodHandles when using Jackson 2.12 Features to Prevent Errors when Jackson 2.11 is Resolved
@alzimmermsft alzimmermsft self-assigned this Mar 18, 2021
@ghost ghost added the Azure.Core azure-core label Mar 18, 2021
@alzimmermsft alzimmermsft added the Client This issue points to a problem in the data-plane of the library. label Mar 18, 2021
g2vinay
g2vinay approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@g2vinay g2vinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is the same code change that was approved in this PR: #19918

Approving this.

@alzimmermsft
Copy link
Member Author

Assuming this is the same code change that was approved in this PR: #19918

Approving this.

Yes, this PR is a cherry-pick of that change

srnagar
srnagar approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just curious about the hotfix branch naming convention. Should we use hotfix/<service>-<version> pattern to be consistent?

@alzimmermsft alzimmermsft merged commit e1d09df into Azure:hotfix/alzimmer/azure-core-1.14.1 Mar 19, 2021
@alzimmermsft alzimmermsft deleted the AzCore_HotfixJackson212ApiUsageFix branch March 19, 2021 01:31
@backwind1233 backwind1233 mentioned this pull request Mar 31, 2021
Merged
@yiliuTo yiliuTo mentioned this pull request Apr 20, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@g2vinay g2vinay g2vinay approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @g2vinay @srnagar