Use Reflection to Configure Jackson 2.12 Features #19918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
alzimmermsft
requested review from
anuchandy,
hemanttanwar,
jianghaolu and
srnagar
as code owners
|
@saragluna, @mrm9084, this should resolve the issues where method and class not found exceptions are being thrown if Jackson resolves to 2.11. @srnagar, @anuchandy, could you take a look at this change. |
srnagar
reviewed
Mar 17, 2021
...json-jackson/src/main/java/com/azure/core/serializer/json/jackson/JacksonJsonSerializer.java
Show resolved
Hide resolved
...json-jackson/src/main/java/com/azure/core/serializer/json/jackson/JacksonJsonSerializer.java
Show resolved
Hide resolved
...json-jackson/src/main/java/com/azure/core/serializer/json/jackson/JacksonJsonSerializer.java
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/serializer/JacksonAdapter.java
Show resolved
Hide resolved
srnagar
approved these changes
Mar 17, 2021
...json-jackson/src/main/java/com/azure/core/serializer/json/jackson/JacksonJsonSerializer.java
Show resolved
Hide resolved
|
Let's add an unreleased tag in version_client.txt for azure-core, so that spring poms can pick it up and validate the azure-core before we patch release. |
|
@alzimmermsft Thanks, I really appreciate this change. |
alzimmermsft
added a commit
to alzimmermsft/azure-sdk-for-java
that referenced
this pull request
Mar 18, 2021
Use MethodHandles when using Jackson 2.12 Features to Prevent Errors when Jackson 2.11 is Resolved
alzimmermsft
added a commit
that referenced
this pull request
Mar 19, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19897
This PR updates
azure-coreandazure-core-serializer-json-jacksonto useMethodHandles when configuring Jackson 2.12 features. The change prevents Core from throwingMethodNotFoundExceptions andClassNotFoundExceptions if Jackson is resolved to 2.11.