Changed logging level in onRequest and onSuccess for service operations from INFO to VERBOSE #19636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
vcolin7
changed the title
srnagar
approved these changes
Mar 5, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Jun 30, 2022
update_web (Azure#19636) * update_web * update_web1 * Update readme.python.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19052.
Had a chat with @srnagar and he agrees that in the case of KV it makes sense to relegate the logging messages of service methods to the
verboselevel, instead ofinfo, as it can negatively impact our customer's environments as described in the issue above. Although there are some operations that normally would not be called repeatedly, I think it's better for consistency that we adopt a stance of logging onverbosefor things likeonRequestandonSuccess.