Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretAsyncClient Fills Logs with Info Messages [BUG] #19052

Closed
3 tasks done
frayneposset opened this issue Feb 8, 2021 · 3 comments · Fixed by #19636
Closed
3 tasks done

SecretAsyncClient Fills Logs with Info Messages [BUG] #19052

frayneposset opened this issue Feb 8, 2021 · 3 comments · Fixed by #19636
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Milestone

Comments

@frayneposset
Copy link

Describe the bug
SecretAsyncClient fills the logs with info messages saying Retrieving secret and Retrieved Secret

Exception or Stack Trace
N/A

To Reproduce
Steps to reproduce the behaviour:

Add this dependency to a Spring Boot app, configure a key vault, then look at the logs.

implementation("com.microsoft.azure:azure-keyvault-secrets-spring-boot-starter:2.3.5")

Code Snippet

    Mono<Response<KeyVaultSecret>> getSecretWithResponse(String name, String version, Context context) {
        context = context == null ? Context.NONE : context;
        return service.getSecret(vaultUrl, name, version == null ? "" : version, apiVersion, ACCEPT_LANGUAGE,
            CONTENT_TYPE_HEADER_VALUE, context.addData(AZ_TRACING_NAMESPACE_KEY, KEYVAULT_TRACING_NAMESPACE_VALUE))
            .doOnRequest(ignoredValue -> logger.info("Retrieving secret - {}", name))
            .doOnSuccess(response -> logger.info("Retrieved secret - {}", response.getValue().getName()))
            .doOnError(error -> logger.warning("Failed to get secret - {}", name, error));

Expected behaviour
These messages should be debug

Screenshots

Setup (please complete the following information):
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 8, 2021
@alzimmermsft alzimmermsft changed the title [BUG] SecretAsyncClient Fills Logs with Info Messages [BUG] Feb 8, 2021
@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. KeyVault labels Feb 8, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 8, 2021
@vcolin7 vcolin7 self-assigned this Feb 8, 2021
@vcolin7 vcolin7 added this to the [2021] March milestone Feb 8, 2021
@vcolin7
Copy link
Member

vcolin7 commented Feb 8, 2021

Hi @frayneposset, this is a pattern we follow in many of our libraries at the time being, but I will definitely bring it up with the team to determine the best course of action.

@madkroll
Copy link

Thanks @frayneposset for opening this issue.
My team also works on integrating our App with Azure Key Vault, but these nonsense INFO log entries are just killing our logging. Each time something tries to retrieve the secret it posts two lines in the log.

I like the idea to set it to DEBUG - so anyone who needs to have that information - may decide to include these records into logging. Please fix it before we ran out of space ahahahahah

@vcolin7
Copy link
Member

vcolin7 commented Mar 5, 2021

@frayneposset @madkroll Changed the log level from INFO to VERBOSE for our service operations in the onRequest and onSuccess methods. These changes should be made available sometime next week :)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants