[Communication] Sms redesign new #19510

paolamvhz · 2021-03-01T09:03:09Z

Support for creating SmsClient with TokenCredential.
Added support for 1:N SMS messaging.
Added support for tagging SMS messages.
Send method series in SmsClient are idempotent under retry policy.

check-enforcer · 2021-03-02T22:05:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

sdk/communication/azure-communication-sms/CHANGELOG.md

sdk/communication/azure-communication-sms/README.md

...e-communication-sms/src/test/java/com/azure/communication/sms/CommunicationLoggerPolicy.java

...n/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsAsyncClientTests.java

...unication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsTestBase.java

...resources/session-records/SmsAsyncClientTests.createAsyncClientUsingConnectionString[1].json

sdk/communication/azure-communication-sms/README.md

...cation/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsAsyncClient.java

sdk/communication/azure-communication-sms/README.md

minnieliu · 2021-03-03T18:01:54Z

A few things that I think architects will have an issue with:

Our async and sync client methods do not have "withResponse" variations on the max overload.
All sycn client methods should have an overload that takes in Context. Usually this is in the "withResponse" variation.

Let's try to fix this before the final review to ensure we have enough time.
cc: @ankitarorabit

sdk/communication/azure-communication-sms/CHANGELOG.md

beltr0n

Formatting throughout, plus potentially an issue with a key in a test file

sdk/communication/azure-communication-sms/README.md

...tion/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsClientBuilder.java

beltr0n · 2021-03-04T01:04:41Z

...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java

-        String endpoint = "https://<RESOURCE_NAME>.communication.azure.com";
+    public void sendMessageToOneRecipient(SmsClient smsClient) {
+        //Send an sms to only one phone number
+        String to = "<to-phone-number>";


just a reminder that we're allowing this as per our convo in teams

...unication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsTestBase.java

sdk/communication/azure-communication-sms/CHANGELOG.md

sdk/communication/azure-communication-sms/README.md

minnieliu · 2021-03-04T17:24:30Z

sdk/communication/azure-communication-sms/README.md

 ```java
+// Create an HttpClient builder of your choice and customize it
+HttpClient httpClient = new NettyAsyncHttpClientBuilder().build();


Extra line. HttpClient httpClient = new NettyAsyncHttpClientBuilder().build(); should not be there

please explain why? This needs to be used in the smsClient

Yes but since it is already in the snippet above, we don't need to keep repeating this line.
We want to keep snippets short

oh it was added a per the suggestion from Ankit I had to have 1 method per example does it needs to be removed or it will be easiest for the user to see everything in one sample?

sdk/communication/azure-communication-sms/README.md

...mmunication/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsClient.java

minnieliu · 2021-03-04T17:31:44Z

...cation/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsClientTests.java

+
+        // Arrange
+        SmsClientBuilder builder = getSmsClient(httpClient);
+        client = setupSyncClient(builder, "sendToSingleUserWithOptions");


name needs to be updated.

...n/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsAsyncClientTests.java

minnieliu · 2021-03-04T17:33:47Z

...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java

+        //addionaly you can ad a tag you wish to identify the messages for this tag.
+        options.setTag("Tag"); /* Optional */
+
+        // Send the message to a list of  phone Numbers and check the response for a messages ids


Can you repeat it here? I am not sure which one you are referring to?

...cation/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsAsyncClient.java

sdk/communication/azure-communication-sms/swagger/README.md

sdk/communication/azure-communication-sms/CHANGELOG.md

minnieliu · 2021-03-04T20:59:15Z

...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java

+    }
+
+    public void sendMessageToMultipleRecipients(SmsClient smsClient) {
+        //Send an sms to multiple phone numbers


It makes it pretty messy. Especially when you have a comment like //Send an sms to multiple phone numbers to to enable a delivery report to the Azure Event Grid I dont think this adds too much value to the snippet.

...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java

minnieliu · 2021-03-04T21:00:07Z

...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java

+        //addionaly you can ad a tag you wish to identify the messages for this tag.
+        options.setTag("Tag"); /* Optional */
+
+        // Send the message to a list of  phone Numbers and check the response for a messages ids


It makes it pretty messy. Especially when you have a comment like //Send an sms to only one phone number to to enable a delivery report to the Azure Event Grid I dont think this adds too much value to the snippet.

...mmunication/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsClient.java

minnieliu · 2021-03-04T21:01:55Z

...mmunication/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsClient.java

-        List<PhoneNumberIdentifier> toList = new ArrayList<PhoneNumberIdentifier>();
-        toList.add(to);
+    @ServiceMethod(returns = ReturnType.SINGLE)
+    public SmsSendResult send(String from, String to, String message, SmsSendOptions smsOptions, Context context) {


You context parameter is not use add all in line 68

To be refactored

...cation/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsAsyncClient.java

minnieliu · 2021-03-04T21:03:25Z

sdk/communication/azure-communication-sms/README.md

 ```java
+// Create an HttpClient builder of your choice and customize it
+HttpClient httpClient = new NettyAsyncHttpClientBuilder().build();


Yes but since it is already in the snippet above, we don't need to keep repeating this line.
We want to keep snippets short

...cation/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsAsyncClient.java

Review request for Microsoft.ContainerService to add version 2022-06-01 (Azure#19848) * Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01 * Updates readme * Updates API version in new specs and examples * update readmes (Azure#19421) * Add key management service profile of a managed cluster for version 2022-06-01 (Azure#19529) * Add NetworkPlugin none option to 2022-06-01 (Azure#19510) * Add NetworkPlugin none option to 2022-06-01 * improve description for none value * Fix violated rule R4041 for 2022-06-01 managedCluster swagger (Azure#19581) * remove useless directive * fix R4041 * GA AKS support for Dedicated Host Group (Azure#19547) * GA AKS support for Dedicated Host Group * fit some format minor issue * add newline in end of files * Defender updates (Azure#19665) * Defender updates * sample * remove old description Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Or Parnes <[email protected]>

Compute update folder structure (Azure#19723) * update folder structure * small errors and CI check * [Language Text] Update swagger titles (Azure#19835) * [Language Text] Update swagger titles * edits * address feedback * Review request for Microsoft.ContainerService to add version 2022-06-01 (Azure#19848) * Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01 * Updates readme * Updates API version in new specs and examples * update readmes (Azure#19421) * Add key management service profile of a managed cluster for version 2022-06-01 (Azure#19529) * Add NetworkPlugin none option to 2022-06-01 (Azure#19510) * Add NetworkPlugin none option to 2022-06-01 * improve description for none value * Fix violated rule R4041 for 2022-06-01 managedCluster swagger (Azure#19581) * remove useless directive * fix R4041 * GA AKS support for Dedicated Host Group (Azure#19547) * GA AKS support for Dedicated Host Group * fit some format minor issue * add newline in end of files * Defender updates (Azure#19665) * Defender updates * sample * remove old description Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Or Parnes <[email protected]> * Update resources.json (Azure#19861) * Pattts/predictive autoscale 20221001 (Azure#19765) * Rev Autoscale API from 2021-05-01-preview to 2022-10-01. * Fix minor swagger issue. Default should be 'false' * Fix swagger validation error * Defining a new package 2022-10 * AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition * Fix require property issue * Run prettier against autoscale_API.json * [Maps - Render & Spatial Services] add v2022-08-01 (Azure#19520) * copy old swagger to new folders * set api version to 2022-08-01 * apply api changes Co-authored-by: Gigi Grajo <[email protected]> * update appconfiguration (Azure#19330) * update appconfiguration * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * [Hub Generated] Publish private branch 'main' (Azure#19852) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> * Merging Dynatrace swagger in stable folder (Azure#19862) * Committing base swagger version * Removing preview tag from stable folder api version * Changing version name in all the files * Updating readme.go and readme.md files * [CDN] Fix customDomains property type in Endpoint (Azure#19788) * [CDN] Fix customDomains property type in Endpoint * Fix linter error Co-authored-by: Bo Zhang <[email protected]> * Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (Azure#19866) * update folders * [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (Azure#19844) * Update description of exportable attribute and release_policy.data * Remove submodule azure-reset-api-specs * Fix description for exportable Co-authored-by: Sunny Solanki <[email protected]> * Add latest StorageMover updates (Azure#19876) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md * Add latest StorageMover updates Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> * Update readme.python.md (Azure#19899) * Update readme.python.md * Update readme.md * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (Azure#19878) * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review * Add known words * Removed static IP allocation only from examples (Azure#19858) * Removed static IP allocation * Removed static only from examples Co-authored-by: Arpit Gagneja <[email protected]> * Update securityinsights readme.python (Azure#19903) * update securityinsights readme.python * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * fix lint errors in Synapse trigger.json (Azure#19660) * put json files into RP folders * update readme * Add CONTRIBUTING.md (Azure#19257) * Add CONTRIBUTING.md * Apply suggestions from PR review Co-authored-by: Heath Stewart <[email protected]> * Apply suggestions from PR review Co-authored-by: Weidong Xu <[email protected]> * Regen toc for CONTRIBUTING.md * Address PR review comments * Address PR review comments Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Weidong Xu <[email protected]> * fix devcenter readme.go.md config (Azure#19906) * fix readme.go.md config * rename to SkuInfo * add annotation for labservices (Azure#19884) * add to description of OS state (Azure#19764) * [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (Azure#19767) * Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item * Update managed hsm private endpoint connection item in mhsm spec for latest api version * Address LRO_RESPONSE_HEADER violation for managed hsm Long running operations that are annotated with x-ms-long-running-operation:true must return location header or azure-AsyncOperation in response. Added the missing location header for managed hsm update command as well as to the corresponding examples. * [Microsoft.DeviceUpdate] Adding first stable API version (Azure#19846) * Copied the most recent preview version into the first stable version * Updated api version in new stable version, added the tag to readme.md * Fixed typo * Fixed the wrong path in readme.md * Reverted VS Code automatic breaking change * Fix broken link (Azure#19688) * add aadObjectId property to kustoPool (Azure#19856) Co-authored-by: Amit Elran <[email protected]> * Updata securityinsights readme.python (Azure#19917) * update securityinsights readme.python * update readme.python Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * modify readme.typescripy.md for compute package (Azure#19607) Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> * Dev gubalasu frontdoor microsoft.network 2021 06 01 (Azure#19578) * Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01 * Updates readme * Updates API version in new specs and examples * update waf configs and examples from 2020-11-01 * Update api version in new specs and examples * Migration api update * Update readme * Fix readme * update readme * Fix readme again * Fix readme * Fix readme * update waf policy provisioning state * Update securityinsights readme.python (Azure#19923) * update securityinsights readme.python * update readme.python * last modify * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * sync with changes made to master * update folder structure * small errors and CI check * update folders * put json files into RP folders * update readme * resolve capitalization and number misplacement accident Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> Co-authored-by: FumingZhang <[email protected]> Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Or Parnes <[email protected]> Co-authored-by: Alexander Batishchev <[email protected]> Co-authored-by: PatrickTseng <[email protected]> Co-authored-by: gigi <[email protected]> Co-authored-by: Gigi Grajo <[email protected]> Co-authored-by: zhenbiao wei <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: Divyansh Agarwal <[email protected]> Co-authored-by: t-bzhan <[email protected]> Co-authored-by: Bo Zhang <[email protected]> Co-authored-by: Uriel Cohen <[email protected]> Co-authored-by: susolank <[email protected]> Co-authored-by: Sunny Solanki <[email protected]> Co-authored-by: Ralf Beckers <[email protected]> Co-authored-by: arpit-gagneja <[email protected]> Co-authored-by: Arpit Gagneja <[email protected]> Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: YanjunGao <[email protected]> Co-authored-by: Mike Kistler <[email protected]> Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Jiahui Peng <[email protected]> Co-authored-by: j-zhong-ms <[email protected]> Co-authored-by: Tom FitzMacken <[email protected]> Co-authored-by: neeerajaakula <[email protected]> Co-authored-by: darkoa-msft <[email protected]> Co-authored-by: Roy Wellington <[email protected]> Co-authored-by: Amit Elran <[email protected]> Co-authored-by: Amit Elran <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: gubalasu <[email protected]>

paolamvhz added 7 commits February 25, 2021 00:33

draft of the implementation

94f7a8b

adding newTestCases

5c37711

adding newTestCases

e8567c1

adding newTestCases

9a7920d

resolving conflicts

06ddd44

resolve conflicts

41fb09f

Draft

618c226

paolamvhz requested review from ankitarorabit, JianpingChen, minnieliu and a team as code owners March 1, 2021 09:03

ghost added the Communication label Mar 1, 2021

paolamvhz added 7 commits March 1, 2021 03:18

fixing pom

12cfe6b

adding change log entry

2fa8579

fixing readme

79a4009

re-generated code

991bb88

Wrapping the SmsResponseItem into SmsSendResult

53d3adb

Wrapping the SmsResponseItem into SmsSendResult

ac6bef6

added with response methods

6c084bc

remove with response methods

daa8262

minnieliu requested changes Mar 2, 2021

View reviewed changes

minnieliu reviewed Mar 2, 2021

View reviewed changes

sdk/communication/azure-communication-sms/README.md Outdated Show resolved Hide resolved

minnieliu requested review from srnagar and RezaJooyandeh March 2, 2021 23:44

ankitarorabit reviewed Mar 3, 2021

View reviewed changes

...cation/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsAsyncClient.java Outdated Show resolved Hide resolved

minnieliu reviewed Mar 3, 2021

View reviewed changes

sdk/communication/azure-communication-sms/README.md Outdated Show resolved Hide resolved

addressing comments

e4b970d

minnieliu requested changes Mar 4, 2021

View reviewed changes

sdk/communication/azure-communication-sms/CHANGELOG.md Outdated Show resolved Hide resolved

beltr0n requested changes Mar 4, 2021

View reviewed changes

paolamvhz added 5 commits March 4, 2021 04:37

addressing comments

9cc92fa

fixing readme

dc1d472

fixing coverage

9791246

fixing readme

dccdf59

fixing test coverage

b539a38

minnieliu reviewed Mar 4, 2021

View reviewed changes

sdk/communication/azure-communication-sms/CHANGELOG.md Outdated Show resolved Hide resolved

minnieliu requested changes Mar 4, 2021

View reviewed changes

sdk/communication/azure-communication-sms/swagger/README.md Outdated Show resolved Hide resolved

fixing code coverage

b278765

minnieliu reviewed Mar 4, 2021

View reviewed changes

sdk/communication/azure-communication-sms/CHANGELOG.md Show resolved Hide resolved

addressing comments

5606e6b

minnieliu requested changes Mar 4, 2021

View reviewed changes

minnieliu reviewed Mar 4, 2021

View reviewed changes

...cation/azure-communication-sms/src/main/java/com/azure/communication/sms/SmsAsyncClient.java Show resolved Hide resolved

paolamvhz added 5 commits March 4, 2021 17:32

addressing comments

45185a1

addressing comments

bac35b0

addressing comments

2915de8

fixing Readme Headers

cfa4e69

fixing Readme dot

13f4e03

minnieliu approved these changes Mar 5, 2021

View reviewed changes

beltr0n approved these changes Mar 5, 2021

View reviewed changes

paolamvhz merged commit 602404b into Azure:master Mar 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Communication] Sms redesign new #19510

[Communication] Sms redesign new #19510

paolamvhz commented Mar 1, 2021

check-enforcer bot commented Mar 2, 2021

minnieliu commented Mar 3, 2021

beltr0n left a comment

beltr0n Mar 4, 2021 •

edited

Loading

minnieliu Mar 4, 2021

paolamvhz Mar 4, 2021

minnieliu Mar 4, 2021

paolamvhz Mar 4, 2021 •

edited

Loading

minnieliu Mar 4, 2021

minnieliu Mar 4, 2021

minnieliu Mar 4, 2021

minnieliu Mar 4, 2021

minnieliu Mar 4, 2021

paolamvhz Mar 4, 2021

minnieliu Mar 4, 2021

[Communication] Sms redesign new #19510

[Communication] Sms redesign new #19510

Conversation

paolamvhz commented Mar 1, 2021

check-enforcer bot commented Mar 2, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

minnieliu commented Mar 3, 2021

beltr0n left a comment

Choose a reason for hiding this comment

beltr0n Mar 4, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paolamvhz Mar 4, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beltr0n Mar 4, 2021 •

edited

Loading

paolamvhz Mar 4, 2021 •

edited

Loading