Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vm miscellaneous #1249

Merged
merged 3 commits into from
Oct 28, 2016
Merged

Vm miscellaneous #1249

merged 3 commits into from
Oct 28, 2016

Conversation

anuchandy
Copy link
Member

@anuchandy anuchandy commented Oct 27, 2016

  1. Renaming few withers to have better consistency (disableVmAgent() -> withoutVmAgent())
  2. Make password required for Windows and password or SSH required for Linux
  3. Adding support for custom data Define vm with custom data #1246
  4. Enable user to specify computer name
  5. Fix the bug of associating availability set to creatable resource group Failed to create Virtual Machine with new resource group and new availability set #1239
  6. unit tests

Compact break from beta-3

  • 6e9ef72
    • Renamed disableVmAgent to withoutVmAgent
    • Renamed disableAutoUpdate to withoutAutoUpdate
    • Removed withPassword and introduced separate methods withRootPassword and withAdminPassword
    • withPassword used to be an optional setter, but the new withAdminPassword is a required stage in case of Windows and withRootPassword or withSsh is required for Linux
    • withRootUserName renamed as withRootUsername

@martinsawicki
Copy link

for whatever we're changing from beta3, can you pls add the compat-breaks label to this PR and list the changes in the comments, for example: #1178, #1140, #1090, etc.

@martinsawicki martinsawicki merged commit ece6b15 into Azure:master Oct 28, 2016
@anuchandy anuchandy deleted the vm-miscellaneous branch February 8, 2017 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants