Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some interface refactoring and renames for better consistency enforcement #1178

Merged
merged 11 commits into from
Oct 12, 2016
Merged

Some interface refactoring and renames for better consistency enforcement #1178

merged 11 commits into from
Oct 12, 2016

Conversation

martinsawicki
Copy link

@martinsawicki martinsawicki commented Oct 8, 2016 •
edited
Loading

any fluent interface that includes has a String-returning name() should not declare that method explicitly, but inherit the new HasName interface from resources. This is also already in the needed base interfaces (like ChildResource, Resource)

compat breaks from beta3:

  • c519966 renames Frontend as LoadBalancerFrontend to better distinguish from ApplicationGatewayFrontend
  • b7e3f3b renames Probe as LoadBalancerProbe to better distinguish from ApplicationGatewayProbe
  • be5ff54 renames TcpProbe as LoadBalancerTcpProbe to help distinguish from ApplicationGatewayTcpProbe
  • 67b3199 renames HttpProbe as LoadBalancerHttpProbe to help distinguish from ApplicationGatewayHttpProbe
  • be39deb renames Backend as LoadBalancerBackend to help distinguish from ApplicationGatewayBackend

unknown added 2 commits October 7, 2016 17:18
minor test cleanup
0c1e37f
extracting name() returning String into a HasName interface acros…
f7d98ac 
…s all fluent interfaces for consistent reuse, less code repetition and single javadoc description
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@martinsawicki martinsawicki changed the title Some interface refactoring for better consistency enforcement Some interface refactoring and renames for better consistency enforcement Oct 11, 2016
@martinsawicki martinsawicki merged commit b807b7a into Azure:master Oct 12, 2016
@martinsawicki martinsawicki mentioned this pull request Oct 27, 2016
Merged
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
Merge pull request Azure#1178 from martinsawicki/martin-plumbing
e176336 
Some interface refactoring and renames for better consistency enforcement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compat breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinsawicki @azuresdkci @azurecla