-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] sdk/resourcemanager/kusto/armkusto/1.1.0 #19124
Conversation
…ec commit: f70b7953f5d54889cc1825b37ad938342ca93a2e
@lirenhe | @ArcturusZhang | @tadelesh |
@Aviv-Yaniv There are some breaking changes caused by our code gen change. We will fix it first and then release the SDK. |
@tadelesh Appreciated! |
@mikekistler @JeffreyRichter I'd like to better understand why we are seeing so many breaking changes. Are these all expected and based on approved swagger breaking changes? cc: @jhendrixMSFT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the number of breaking changes, I'd like Mike/Jeffrey to review.
@RickWinter This breaking is not from swagger. It is from the codegen change. Joel and I are working on it. |
@JeffreyRichter I want to confirm with you such removal of unreferenced types ( |
Technically this is breaking because customers could have used the types in their code even if they can't use them to talk to the service. However, we (the Azure Breaking Change Board) have been approving these as non-breaking because the chance of breaking customers is so low as they had no reason to use these types. And so, in this case we do NOT bump the major version. |
@RickWinter Please sign off. |
b4a1dbe
to
fd1c429
Compare
@RickWinter Gentle ping to review |
@tadelesh Could we mere please? |
https://github.com/Azure/sdk-release-request/issues/3168