Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] sdk/resourcemanager/kusto/armkusto/1.1.0 #19124

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

azure-sdk
Copy link
Collaborator

…ec commit: f70b7953f5d54889cc1825b37ad938342ca93a2e
@Aviv-Yaniv
Copy link

@lirenhe | @ArcturusZhang | @tadelesh
Please merge :)

@tadelesh
Copy link
Member

@Aviv-Yaniv There are some breaking changes caused by our code gen change. We will fix it first and then release the SDK.

@Aviv-Yaniv
Copy link

@tadelesh Appreciated!

@RickWinter
Copy link
Member

@mikekistler @JeffreyRichter I'd like to better understand why we are seeing so many breaking changes. Are these all expected and based on approved swagger breaking changes?

cc: @jhendrixMSFT

Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the number of breaking changes, I'd like Mike/Jeffrey to review.

@tadelesh
Copy link
Member

tadelesh commented Sep 16, 2022

Given the number of breaking changes, I'd like Mike/Jeffrey to review.

@RickWinter This breaking is not from swagger. It is from the codegen change. Joel and I are working on it.

@tadelesh
Copy link
Member

@JeffreyRichter I want to confirm with you such removal of unreferenced types (CloudError and CloudErrorBody are not used in any operations) should also be considered a client breaking and pump major version, right?

@JeffreyRichter
Copy link
Member

JeffreyRichter commented Sep 19, 2022

Technically this is breaking because customers could have used the types in their code even if they can't use them to talk to the service. However, we (the Azure Breaking Change Board) have been approving these as non-breaking because the chance of breaking customers is so low as they had no reason to use these types.

And so, in this case we do NOT bump the major version.

@tadelesh tadelesh changed the title [Release] sdk/resourcemanager/kusto/armkusto/2.0.0 [Release] sdk/resourcemanager/kusto/armkusto/1.1.0 Sep 20, 2022
@tadelesh
Copy link
Member

@RickWinter Please sign off.

@tadelesh tadelesh requested a review from RickWinter September 20, 2022 02:03
@tadelesh tadelesh force-pushed the release-kusto-armkusto-2.0.0-1663203879 branch from b4a1dbe to fd1c429 Compare September 20, 2022 02:33
@Aviv-Yaniv
Copy link

@RickWinter Gentle ping to review

@Aviv-Yaniv
Copy link

@tadelesh Could we mere please?

@tadelesh tadelesh merged commit e248e40 into main Sep 21, 2022
@tadelesh tadelesh deleted the release-kusto-armkusto-2.0.0-1663203879 branch September 21, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants