Opt-in omit x-ms-external model generation #877
Conversation
tadelesh
requested review from
chlowell,
jhendrixMSFT,
RickWinter,
ArcturusZhang and
lirenhe
as code owners
|
Can you please provide some examples of how this is breaking existing modules? |
@jhendrixMSFT Some recent releases of mgmt. modules got breaking changes by this: kusto: Azure/azure-sdk-for-go#19124, swagger |
|
@jhendrixMSFT Many releases are blocked by this. Could you help to review ASAP. Thanks. |
|
Can we not work around these by way of transformation? Or are there more than just three releases? |
| @@ -25,7 +25,8 @@ export async function generateModels(session: Session<CodeModel>): Promise<model | |||
| let modelText = await contentPreamble(session); | |||
|
|
|||
| // we do model generation first as it can add imports to the imports list | |||
| const structs = generateStructs(modelImports, serdeImports, session.model.schemas.objects); | |||
| const omitXMsExternal = await session.getValue('omit-x-ms-external', true); | |||
There was a problem hiding this comment.
I would prefer that the default is false, and that if azure-arm is true then we can default this to true.
|
@jhendrixMSFT I think this change could be closed as Jeff said the removal of unreferenced type could be treated as non-breaking change (link). |
Resolve #876