Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DefaultAzureCredential #4409

Merged
merged 9 commits into from
Mar 8, 2023
Merged

Conversation

antkmsft
Copy link
Member

@antkmsft antkmsft commented Mar 6, 2023

Closes #82.

It is all the credential that I presented earlier, implementation is very simple, but 95% of other changes are instrumenting the code with log messages, and covering all that with tests + update to the docs (heavily borrowed from .NET SDK's identity readme)

Here is how the logs look like when you use DefaultAzureCredential: https://github.com/Azure/azure-sdk-for-cpp/blob/51df426b557f8b29c2037aba53500418c73e8d07/sdk/identity/azure-identity/test/ut/default_azure_credential_test.cpp

@antkmsft antkmsft self-assigned this Mar 6, 2023
@antkmsft antkmsft changed the title Added DefaultAzureCredential Add DefaultAzureCredential Mar 6, 2023
@Azure Azure deleted a comment from azure-pipelines bot Mar 7, 2023
@antkmsft antkmsft marked this pull request as ready for review March 7, 2023 00:20
Copy link
Member

@gearama gearama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ancient bug 80s range

@antkmsft
Copy link
Member Author

antkmsft commented Mar 7, 2023

This came up a couple times already, so I am posting for everyone's view - here is how the logs look like when you use DefaultAzureCredential: https://github.com/Azure/azure-sdk-for-cpp/blob/51df426b557f8b29c2037aba53500418c73e8d07/sdk/identity/azure-identity/test/ut/default_azure_credential_test.cpp

@Azure Azure deleted a comment from azure-pipelines bot Mar 8, 2023
@antkmsft
Copy link
Member Author

antkmsft commented Mar 8, 2023

/azp run cpp - identity

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antkmsft antkmsft merged commit fc61bb4 into Azure:main Mar 8, 2023
antkmsft added a commit that referenced this pull request Apr 5, 2023
* Added DefaultAzureCredential

* Improved Llgging

---------

Co-authored-by: Anton Kolesnyk <[email protected]>
@antkmsft antkmsft deleted the default-azure-cred branch April 25, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Default Azure Credential
5 participants