-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DefaultAzureCredential #4409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ancient bug 80s range
sdk/identity/azure-identity/inc/azure/identity/chained_token_credential.hpp
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/inc/azure/identity/default_azure_credential.hpp
Show resolved
Hide resolved
This came up a couple times already, so I am posting for everyone's view - here is how the logs look like when you use DefaultAzureCredential: https://github.com/Azure/azure-sdk-for-cpp/blob/51df426b557f8b29c2037aba53500418c73e8d07/sdk/identity/azure-identity/test/ut/default_azure_credential_test.cpp |
… not be defined when RTTI is off
/azp run cpp - identity |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/identity/azure-identity/inc/azure/identity/chained_token_credential.hpp
Show resolved
Hide resolved
sdk/identity/azure-identity/inc/azure/identity/default_azure_credential.hpp
Show resolved
Hide resolved
sdk/identity/azure-identity/inc/azure/identity/default_azure_credential.hpp
Show resolved
Hide resolved
* Added DefaultAzureCredential * Improved Llgging --------- Co-authored-by: Anton Kolesnyk <[email protected]>
Closes #82.
It is all the credential that I presented earlier, implementation is very simple, but 95% of other changes are instrumenting the code with log messages, and covering all that with tests + update to the docs (heavily borrowed from .NET SDK's identity readme)
Here is how the logs look like when you use DefaultAzureCredential: https://github.com/Azure/azure-sdk-for-cpp/blob/51df426b557f8b29c2037aba53500418c73e8d07/sdk/identity/azure-identity/test/ut/default_azure_credential_test.cpp