Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should DefaultAzureCredential expose that it is using ChainedTokenCredential? #4419

Closed
antkmsft opened this issue Mar 8, 2023 · 0 comments · Fixed by #4447
Closed

Should DefaultAzureCredential expose that it is using ChainedTokenCredential? #4419

antkmsft opened this issue Mar 8, 2023 · 0 comments · Fixed by #4447
Assignees
@antkmsft
Labels
Azure.Identity bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.

Comments

@antkmsft
Copy link
Member

antkmsft commented Mar 8, 2023

I'd rather let the user know that DefaultAzureCredential is using ChainedTokenCredential, so that should they want to build their own credential chain, or customize it, the credential suggests the next step for them.

But there is opinion to not expose it, so that is why I am opening this issue - to discuss it.

If we decide to not expose it, let's also update README.md and DefaultAzureCredential's doxygen coments, because we documented it there.

See #4409 (comment)
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 8, 2023
This was referenced Mar 8, 2023
Merged
Merged
@RickWinter RickWinter added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Mar 10, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 10, 2023
@antkmsft antkmsft mentioned this issue Mar 15, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@antkmsft antkmsft

Labels
Azure.Identity bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
2 participants
@RickWinter @antkmsft