Add AssessPatches API #9275
Merged
Add AssessPatches API #9275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-js
|
azure-sdk-for-net
|
azure-sdk-for-trenton
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Can one of the admins verify this patch? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fengzhou-msft
added
the
WaitForARMFeedback
openapi-assignment-bot
bot
removed
the
WaitForARMFeedback
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
hyonholee
force-pushed
the
compute-2020-06
branch
from
0924085 to
b31fd02
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
hyonholee
reviewed
May 12, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Show resolved
Hide resolved
hyonholee
reviewed
May 12, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Outdated
Show resolved
Hide resolved
hyonholee
reviewed
May 12, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Show resolved
Hide resolved
hyonholee
reviewed
May 12, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Show resolved
Hide resolved
|
/azp run |
[Staging] Swagger Validation Report️~[Staging] BreakingChange [Detail]Posted by Swagger Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
@ravbhatnagar Could you review this PR? BTW, this PR is against compute-2020-06 branch, so breaking change is expected. We are collecting all update for 2020-06 API version and will send a PR from compute-2020-06 branch to master |
hari-bodicherla
force-pushed
the
compute-2020-06
branch
from
f904c0e to
aec83a3
Compare
|
@ravbhatnagar, pinging for status of this PR. Could you review this PR? |
hyonholee
reviewed
Jun 5, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
pilor
reviewed
Jun 5, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Outdated
Show resolved
Hide resolved
pilor
reviewed
Jun 5, 2020
| "readOnly": true, | ||
| "format": "date-time", | ||
| "description": "The UTC timestamp of the last update of this result object." | ||
| }, |
There was a problem hiding this comment.
when does this and the "InProgress" state come into play? With the 202 + location header async pattern the user is not going to get a result until the operation is complete.
There was a problem hiding this comment.
The intention with those two properties is consistency of results so that the data returned directly, the data acquired via GET InstanceView, and the data acquired via the upcoming installationResults API all align. LastModifiedDateTime and "status": "InProgress" make more sense in the context of InstanceView.
In terms of this specific API, "InProgress" is unlikely to ever be returned since it should not return results until the operation completes, but the underlying enum in the code contains the value so I thought I had to include it here.
There was a problem hiding this comment.
I thought about it some more and the lastModifiedDateTime doesn't really make sense since it is obviously the time when the response is returned. I removed it.
pilor
reviewed
Jun 5, 2020
| "type": "array", | ||
| "readOnly": true, | ||
| "items": { | ||
| "x-ms-client-flatten": true, |
There was a problem hiding this comment.
"x-ms-client-flatten": true, [](start = 12, length = 28)
does this have any effect? How does an array get flattened in SDKs?
There was a problem hiding this comment.
I found the documentation here. I think the answer to your question is, "yes." The results are included as I expected them to be in the SDK (A list of patch objects without additional "properties" objects or nesting inside them). I don't know if it would have been generated that way without the extension tag.
pilor
reviewed
Jun 5, 2020
specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Show resolved
Hide resolved
pilor
added
ARMChangesRequested
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pilor
added
ARMSignedOff
pilor
approved these changes
Jun 8, 2020
ArcturusZhang
pushed a commit
that referenced
this pull request
Jun 23, 2020
* Preparatory commit for compute 2020-06-01 API version * Auto patch swagger change (#9524) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * Preparatory commit for compute 2020-06-01 API version * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * fixing merge conflict * fixing the checks * adding reference to the example * fixing the checks error * fixing the example validation * running prettier Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> * Revert the breaking change * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9520) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Hyonho Lee <[email protected]> * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (#9666) * Preparatory commit for compute 2020-06-01 API version * updated swagger * updated swagger * fixed the prettier issues * updated the documentation' * Preparatory commit for compute 2020-06-01 API version * resolved * updated code * resolved conflicts * udpated comments * updated code * resolved prettier fix Co-authored-by: Hyonho Lee <[email protected]> * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (#9460) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Addressing minor corrections in examples related PR#9460 (#9685) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma * Addressing pending review changes. Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Add AssessPatches API (#9275) * Initial commit with updates to compute.json for assessPatches and softwarePatches * Add VirtualMachinesAssessPatches.json * Fix minor issues with softwarePatches * Updates to correct the example per oav * Remove GET and LIST softwarePatches * Remove unneeded list result * update description strings * Add kbid to spell check list. Include Prettier formating changes. * Update SoftwarePatch.InstallationState to AssessmentState * Remove extra properties from patch object array * Fix name of PublishedDate * Add generic error response * Add readonly, make rebootPending a boolean again * Remove LastModifiedDateTime from result object * Adding ExtensionsTimeBudget to new Api Version (#9319) * fixing encoding (+2 squashed commit) Squashed commit: [e73eef7] Prettier [68d011b] adding 201 response (+1 squashed commits) Squashed commits: [83f71bb48] Adding references (+1 squashed commits) Squashed commits: [d8ed894] updating GET example (+1 squashed commits) Squashed commits: [61920933d] fix (+1 squashed commits) Squashed commits: [f0151eb78] updated with extensionsTimeBudget * fixing file name Co-authored-by: Hyonho Lee <[email protected]> * Changes related to dedicated host group automatic placement (#9684) * Made changes for dedicated host group instance view * Added definitions for dedicated host group instance view * Made changes for SupportAutomaticPlacement * Made changes for assigned host * Made changes on properties.hostGroup * Added a missing comma * Addressed comments * Updated * Added assignedHost to VMScaleSetVMInstanceView * Addressed comments * Added minimum API version for assignedHost * Addressed comments * ModelAsString to false * Added exmples for VM * Added examples for VMSS * small fix * Addressed comments * Added missing parameter * Fixed examples * Add example for VMSS RunCommand (#9875) Co-authored-by: Jemal Abdulkadir <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: Avinash <[email protected]> Co-authored-by: Avinash Akka <[email protected]> Co-authored-by: Mike Richmond <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: dochung4 <[email protected]> Co-authored-by: Atanas Koralski <[email protected]>
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Preparatory commit for compute 2020-06-01 API version * Auto patch swagger change (Azure#9524) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * Preparatory commit for compute 2020-06-01 API version * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * fixing merge conflict * fixing the checks * adding reference to the example * fixing the checks error * fixing the example validation * running prettier Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> * Revert the breaking change * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9520) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Hyonho Lee <[email protected]> * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (Azure#9666) * Preparatory commit for compute 2020-06-01 API version * updated swagger * updated swagger * fixed the prettier issues * updated the documentation' * Preparatory commit for compute 2020-06-01 API version * resolved * updated code * resolved conflicts * udpated comments * updated code * resolved prettier fix Co-authored-by: Hyonho Lee <[email protected]> * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (Azure#9460) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Addressing minor corrections in examples related PR#9460 (Azure#9685) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma * Addressing pending review changes. Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Add AssessPatches API (Azure#9275) * Initial commit with updates to compute.json for assessPatches and softwarePatches * Add VirtualMachinesAssessPatches.json * Fix minor issues with softwarePatches * Updates to correct the example per oav * Remove GET and LIST softwarePatches * Remove unneeded list result * update description strings * Add kbid to spell check list. Include Prettier formating changes. * Update SoftwarePatch.InstallationState to AssessmentState * Remove extra properties from patch object array * Fix name of PublishedDate * Add generic error response * Add readonly, make rebootPending a boolean again * Remove LastModifiedDateTime from result object * Adding ExtensionsTimeBudget to new Api Version (Azure#9319) * fixing encoding (+2 squashed commit) Squashed commit: [e73eef7] Prettier [68d011b] adding 201 response (+1 squashed commits) Squashed commits: [83f71bb48] Adding references (+1 squashed commits) Squashed commits: [d8ed894] updating GET example (+1 squashed commits) Squashed commits: [61920933d] fix (+1 squashed commits) Squashed commits: [f0151eb78] updated with extensionsTimeBudget * fixing file name Co-authored-by: Hyonho Lee <[email protected]> * Changes related to dedicated host group automatic placement (Azure#9684) * Made changes for dedicated host group instance view * Added definitions for dedicated host group instance view * Made changes for SupportAutomaticPlacement * Made changes for assigned host * Made changes on properties.hostGroup * Added a missing comma * Addressed comments * Updated * Added assignedHost to VMScaleSetVMInstanceView * Addressed comments * Added minimum API version for assignedHost * Addressed comments * ModelAsString to false * Added exmples for VM * Added examples for VMSS * small fix * Addressed comments * Added missing parameter * Fixed examples * Add example for VMSS RunCommand (Azure#9875) Co-authored-by: Jemal Abdulkadir <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: Avinash <[email protected]> Co-authored-by: Avinash Akka <[email protected]> Co-authored-by: Mike Richmond <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: dochung4 <[email protected]> Co-authored-by: Atanas Koralski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the POST AssessPatches action to the compute swagger spec.
SDK tests now pass.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.