-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding DisallowedConfiguration property to VirtualMachineImageProperties #9065
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
azure-cli-extensions
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-java
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-net
|
Can one of the admins verify this patch? |
including @jerryc3 |
Adding new properties to a stable api-version is a breaking change. This change must go in a new api-version. @sirajudeens - FYI. |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-trenton
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ravbhatnagar This PR is targeted to the branch for new compute API version. We will gather all changes to this branch and then send a PR to master. |
* Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * Preparatory commit for compute 2020-06-01 API version * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * fixing merge conflict * fixing the checks * adding reference to the example * fixing the checks error * fixing the example validation * running prettier Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
… diagnostics changes with examples. (#9460) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]>
* Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma * Addressing pending review changes. Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]>
* Preparatory commit for compute 2020-06-01 API version * Auto patch swagger change (#9524) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * Preparatory commit for compute 2020-06-01 API version * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * fixing merge conflict * fixing the checks * adding reference to the example * fixing the checks error * fixing the example validation * running prettier Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> * Revert the breaking change * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9520) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Hyonho Lee <[email protected]> * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (#9666) * Preparatory commit for compute 2020-06-01 API version * updated swagger * updated swagger * fixed the prettier issues * updated the documentation' * Preparatory commit for compute 2020-06-01 API version * resolved * updated code * resolved conflicts * udpated comments * updated code * resolved prettier fix Co-authored-by: Hyonho Lee <[email protected]> * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (#9460) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Addressing minor corrections in examples related PR#9460 (#9685) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma * Addressing pending review changes. Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Add AssessPatches API (#9275) * Initial commit with updates to compute.json for assessPatches and softwarePatches * Add VirtualMachinesAssessPatches.json * Fix minor issues with softwarePatches * Updates to correct the example per oav * Remove GET and LIST softwarePatches * Remove unneeded list result * update description strings * Add kbid to spell check list. Include Prettier formating changes. * Update SoftwarePatch.InstallationState to AssessmentState * Remove extra properties from patch object array * Fix name of PublishedDate * Add generic error response * Add readonly, make rebootPending a boolean again * Remove LastModifiedDateTime from result object * Adding ExtensionsTimeBudget to new Api Version (#9319) * fixing encoding (+2 squashed commit) Squashed commit: [e73eef7] Prettier [68d011b] adding 201 response (+1 squashed commits) Squashed commits: [83f71bb48] Adding references (+1 squashed commits) Squashed commits: [d8ed894] updating GET example (+1 squashed commits) Squashed commits: [61920933d] fix (+1 squashed commits) Squashed commits: [f0151eb78] updated with extensionsTimeBudget * fixing file name Co-authored-by: Hyonho Lee <[email protected]> * Changes related to dedicated host group automatic placement (#9684) * Made changes for dedicated host group instance view * Added definitions for dedicated host group instance view * Made changes for SupportAutomaticPlacement * Made changes for assigned host * Made changes on properties.hostGroup * Added a missing comma * Addressed comments * Updated * Added assignedHost to VMScaleSetVMInstanceView * Addressed comments * Added minimum API version for assignedHost * Addressed comments * ModelAsString to false * Added exmples for VM * Added examples for VMSS * small fix * Addressed comments * Added missing parameter * Fixed examples * Add example for VMSS RunCommand (#9875) Co-authored-by: Jemal Abdulkadir <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: Avinash <[email protected]> Co-authored-by: Avinash Akka <[email protected]> Co-authored-by: Mike Richmond <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: dochung4 <[email protected]> Co-authored-by: Atanas Koralski <[email protected]>
* Preparatory commit for compute 2020-06-01 API version * Auto patch swagger change (Azure#9524) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * Preparatory commit for compute 2020-06-01 API version * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * Adding in-guest vm patch propertyies to VM model * making the enum model as string * adding the change to end of the file for easy comparison * Fixing the name of the property * fixing merge conflict * fixing the checks * adding reference to the example * fixing the checks error * fixing the example validation * running prettier Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> * Revert the breaking change * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9520) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Hyonho Lee <[email protected]> * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (Azure#9666) * Preparatory commit for compute 2020-06-01 API version * updated swagger * updated swagger * fixed the prettier issues * updated the documentation' * Preparatory commit for compute 2020-06-01 API version * resolved * updated code * resolved conflicts * udpated comments * updated code * resolved prettier fix Co-authored-by: Hyonho Lee <[email protected]> * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (Azure#9460) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Addressing minor corrections in examples related PR#9460 (Azure#9685) * Preparatory commit for compute 2020-06-01 API version * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065) * managed boot diagnostics changes. * Add new lines to the EOF. * Adding missing response schema. * Preparatory commit for compute 2020-06-01 API version * Adding default error response. * Review comments. * Remove extra comma * Addressing pending review changes. Co-authored-by: Hyonho Lee <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: Avinash Akka <[email protected]> * Add AssessPatches API (Azure#9275) * Initial commit with updates to compute.json for assessPatches and softwarePatches * Add VirtualMachinesAssessPatches.json * Fix minor issues with softwarePatches * Updates to correct the example per oav * Remove GET and LIST softwarePatches * Remove unneeded list result * update description strings * Add kbid to spell check list. Include Prettier formating changes. * Update SoftwarePatch.InstallationState to AssessmentState * Remove extra properties from patch object array * Fix name of PublishedDate * Add generic error response * Add readonly, make rebootPending a boolean again * Remove LastModifiedDateTime from result object * Adding ExtensionsTimeBudget to new Api Version (Azure#9319) * fixing encoding (+2 squashed commit) Squashed commit: [e73eef7] Prettier [68d011b] adding 201 response (+1 squashed commits) Squashed commits: [83f71bb48] Adding references (+1 squashed commits) Squashed commits: [d8ed894] updating GET example (+1 squashed commits) Squashed commits: [61920933d] fix (+1 squashed commits) Squashed commits: [f0151eb78] updated with extensionsTimeBudget * fixing file name Co-authored-by: Hyonho Lee <[email protected]> * Changes related to dedicated host group automatic placement (Azure#9684) * Made changes for dedicated host group instance view * Added definitions for dedicated host group instance view * Made changes for SupportAutomaticPlacement * Made changes for assigned host * Made changes on properties.hostGroup * Added a missing comma * Addressed comments * Updated * Added assignedHost to VMScaleSetVMInstanceView * Addressed comments * Added minimum API version for assignedHost * Addressed comments * ModelAsString to false * Added exmples for VM * Added examples for VMSS * small fix * Addressed comments * Added missing parameter * Fixed examples * Add example for VMSS RunCommand (Azure#9875) Co-authored-by: Jemal Abdulkadir <[email protected]> Co-authored-by: Sirajudeen Sahul Hameed <[email protected]> Co-authored-by: hari-bodicherla <[email protected]> Co-authored-by: Avinash <[email protected]> Co-authored-by: Avinash Akka <[email protected]> Co-authored-by: Mike Richmond <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: dochung4 <[email protected]> Co-authored-by: Atanas Koralski <[email protected]>
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.