Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DisallowedConfiguration property to VirtualMachineImageProperties #9065

Merged
merged 1 commit into from
May 11, 2020

Conversation

sirajudeens
Copy link
Contributor

@sirajudeens sirajudeens commented Apr 15, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 15, 2020

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 15, 2020

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 84d2dd4 with merge commit c615e46877fec73bfe68f6897d2b285830b1f7eb. SDK Automation 13.0.17.20200424.4
  • ⚠️compute/mgmt/2015-06-15 [Logs
      No file is changed.
    • ⚠️compute/mgmt/2016-03-30 [Logs
        No file is changed.
      • ⚠️compute/mgmt/2017-03-30 [Logs
          No file is changed.
        • ⚠️compute/mgmt/2017-09-01 [Logs
            No file is changed.
          • ⚠️compute/mgmt/2017-12-01 [Logs
              No file is changed.
            • ⚠️compute/mgmt/2018-04-01 [Logs
                No file is changed.
              • ⚠️compute/mgmt/2018-06-01 [Logs
                  No file is changed.
                • ⚠️compute/mgmt/2018-10-01 [Logs
                    No file is changed.
                  • ⚠️compute/mgmt/2019-03-01 [Logs
                      No file is changed.
                    • ⚠️compute/mgmt/2019-07-01 [Logs
                        No file is changed.
                      • ⚠️compute/mgmt/2019-12-01 [Logs
                          No file is changed.
                        • ⚠️containerservice/mgmt/2016-03-30 [Logs
                            No file is changed.
                          • ⚠️containerservice/mgmt/2016-09-30 [Logs
                              No file is changed.
                            • ⚠️containerservice/mgmt/2017-01-31 [Logs
                                No file is changed.
                              • ⚠️preview/compute/mgmt/2016-04-30-preview [Logs
                                  No file is changed.
                                • ⚠️preview/containerservice/mgmt/2015-11-01-preview [Logs
                                    No file is changed.

                                  @openapi-sdkautomation
                                  Copy link

                                  openapi-sdkautomation bot commented Apr 15, 2020

                                  azure-sdk-for-js

                                  ️✔️ succeeded [Logs] [Expand Details]

                                  @openapi-sdkautomation
                                  Copy link

                                  openapi-sdkautomation bot commented Apr 15, 2020

                                  azure-sdk-for-java

                                  ⚠️ warning [Logs] [Expand Details]
                                  • ⚠️ Generate from 84d2dd4 with merge commit c615e46877fec73bfe68f6897d2b285830b1f7eb. SDK Automation 13.0.17.20200424.4
                                  • ⚠️sdk/compute/mgmt-v2017_03_30 [Logs
                                      No file is changed.
                                    • ⚠️sdk/compute/mgmt-v2017_09_01 [Logs
                                        No file is changed.
                                      • ⚠️sdk/compute/mgmt-v2017_12_01 [Logs
                                          No file is changed.
                                        • ⚠️sdk/compute/mgmt-v2018_04_01 [Logs
                                            No file is changed.

                                          @openapi-sdkautomation
                                          Copy link

                                          openapi-sdkautomation bot commented Apr 15, 2020

                                          azure-sdk-for-python

                                          - Breaking Change detected in SDK

                                          ⚠️ warning [Logs] [Expand Details]
                                          • ⚠️ Generate from 84d2dd4 with merge commit c615e46877fec73bfe68f6897d2b285830b1f7eb. SDK Automation 13.0.17.20200424.4
                                          • ⚠️azure-mgmt-compute [Logs]  [Preview SDK Changes] Breaking Change Detected
                                            [build_conf] INFO:packaging_tools:Building template azure-mgmt-compute
                                            [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
                                            [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
                                            [build_conf] INFO:packaging_tools:Template done azure-mgmt-compute
                                            [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                            [build_package]   warnings.warn(msg)
                                            [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
                                            [build_package]   warnings.warn(msg)
                                            [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
                                            [breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
                                            [breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
                                            [ChangeLog] Size of delta 0.600% size of original (original: 204970 chars, delta: 1229 chars)
                                            [ChangeLog] **Features**
                                            [ChangeLog] 
                                            [ChangeLog]   - Model DiffDiskSettings has a new parameter placement
                                            [ChangeLog]   - Added operation VirtualMachinesOperations.simulate_eviction
                                            [ChangeLog]   - Added operation VirtualMachineScaleSetVMsOperations.simulate_eviction
                                            [ChangeLog] 
                                            [ChangeLog] **Breaking changes**
                                            [ChangeLog] 
                                            [ChangeLog]   - Operation VirtualMachineScaleSetsOperations.set_orchestration_service_state has a new signature

                                          @openapi-sdkautomation
                                          Copy link

                                          openapi-sdkautomation bot commented Apr 15, 2020

                                          azure-sdk-for-net

                                          ️✔️ succeeded [Logs] [Expand Details]

                                          @azuresdkci
                                          Copy link
                                          Contributor

                                          Can one of the admins verify this patch?

                                          @fengzhou-msft fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 15, 2020
                                          @sirajudeens sirajudeens changed the title Adding DisallowedConfiguragion property to VirtualMachineImageProperties Adding DisallowedConfiguration property to VirtualMachineImageProperties Apr 15, 2020
                                          @openapi-assignment-bot openapi-assignment-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 15, 2020
                                          @hyonholee hyonholee added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 15, 2020
                                          @openapi-assignment-bot openapi-assignment-bot bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 16, 2020
                                          @sirajudeens
                                          Copy link
                                          Contributor Author

                                          including @jerryc3

                                          @ravbhatnagar
                                          Copy link
                                          Contributor

                                          Adding new properties to a stable api-version is a breaking change. This change must go in a new api-version. @sirajudeens - FYI.

                                          @ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 17, 2020
                                          @sirajudeens sirajudeens changed the title Adding DisallowedConfiguration property to VirtualMachineImageProperties [DoNotMerge]Adding DisallowedConfiguration property to VirtualMachineImageProperties Apr 17, 2020
                                          @sirajudeens sirajudeens changed the title [DoNotMerge]Adding DisallowedConfiguration property to VirtualMachineImageProperties Adding DisallowedConfiguration property to VirtualMachineImageProperties May 5, 2020
                                          @sirajudeens sirajudeens changed the title Adding DisallowedConfiguration property to VirtualMachineImageProperties [DoNotMerge] Adding DisallowedConfiguration property to VirtualMachineImageProperties May 5, 2020
                                          @azure-pipelines
                                          Copy link

                                          Azure Pipelines successfully started running 1 pipeline(s).

                                          @openapi-sdkautomation
                                          Copy link

                                          openapi-sdkautomation bot commented May 5, 2020

                                          azure-sdk-for-trenton

                                          No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

                                          @hyonholee hyonholee changed the base branch from master to compute-2020-06 May 5, 2020 19:51
                                          Copy link
                                          Contributor

                                          @hyonholee hyonholee left a comment

                                          Choose a reason for hiding this comment

                                          The reason will be displayed to describe this comment to others. Learn more.

                                          LGTM

                                          @hyonholee
                                          Copy link
                                          Contributor

                                          @ravbhatnagar This PR is targeted to the branch for new compute API version. We will gather all changes to this branch and then send a PR to master.

                                          @hyonholee hyonholee changed the title [DoNotMerge] Adding DisallowedConfiguration property to VirtualMachineImageProperties Adding DisallowedConfiguration property to VirtualMachineImageProperties May 11, 2020
                                          @hyonholee hyonholee merged this pull request into Azure:compute-2020-06 May 11, 2020
                                          hyonholee added a commit that referenced this pull request May 28, 2020
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065)
                                          
                                          * Adding in-guest vm patch propertyies to VM model
                                          
                                          * making the enum model as string
                                          
                                          * adding the change to end of the file for easy comparison
                                          
                                          * Fixing the name of the property
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065)
                                          
                                          * Adding in-guest vm patch propertyies to VM model
                                          
                                          * making the enum model as string
                                          
                                          * adding the change to end of the file for easy comparison
                                          
                                          * Fixing the name of the property
                                          
                                          * fixing merge conflict
                                          
                                          * fixing the checks
                                          
                                          * adding reference to the example
                                          
                                          * fixing the checks error
                                          
                                          * fixing the example validation
                                          
                                          * running prettier
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          hyonholee added a commit that referenced this pull request Jun 3, 2020
                                          … diagnostics changes with examples. (#9460)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065)
                                          
                                          * managed boot diagnostics changes.
                                          
                                          * Add new lines to the EOF.
                                          
                                          * Adding missing response schema.
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding default error response.
                                          
                                          * Review comments.
                                          
                                          * Remove extra comma
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          Co-authored-by: Avinash Akka <[email protected]>
                                          ArcturusZhang pushed a commit that referenced this pull request Jun 3, 2020
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065)
                                          
                                          * managed boot diagnostics changes.
                                          
                                          * Add new lines to the EOF.
                                          
                                          * Adding missing response schema.
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding default error response.
                                          
                                          * Review comments.
                                          
                                          * Remove extra comma
                                          
                                          * Addressing pending review changes.
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          Co-authored-by: Avinash Akka <[email protected]>
                                          ArcturusZhang pushed a commit that referenced this pull request Jun 23, 2020
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Auto patch swagger change (#9524)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065)
                                          
                                          * Adding in-guest vm patch propertyies to VM model
                                          
                                          * making the enum model as string
                                          
                                          * adding the change to end of the file for easy comparison
                                          
                                          * Fixing the name of the property
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065)
                                          
                                          * Adding in-guest vm patch propertyies to VM model
                                          
                                          * making the enum model as string
                                          
                                          * adding the change to end of the file for easy comparison
                                          
                                          * Fixing the name of the property
                                          
                                          * fixing merge conflict
                                          
                                          * fixing the checks
                                          
                                          * adding reference to the example
                                          
                                          * fixing the checks error
                                          
                                          * fixing the example validation
                                          
                                          * running prettier
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          
                                          * Revert the breaking change
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9520)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          
                                          * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (#9666)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * updated swagger
                                          
                                          * updated swagger
                                          
                                          * fixed the prettier issues
                                          
                                          * updated the documentation'
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * resolved
                                          
                                          * updated code
                                          
                                          * resolved conflicts
                                          
                                          * udpated comments
                                          
                                          * updated code
                                          
                                          * resolved prettier fix
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          
                                          * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (#9460)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065)
                                          
                                          * managed boot diagnostics changes.
                                          
                                          * Add new lines to the EOF.
                                          
                                          * Adding missing response schema.
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding default error response.
                                          
                                          * Review comments.
                                          
                                          * Remove extra comma
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          Co-authored-by: Avinash Akka <[email protected]>
                                          
                                          * Addressing minor corrections in examples related PR#9460 (#9685)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (#9065)
                                          
                                          * managed boot diagnostics changes.
                                          
                                          * Add new lines to the EOF.
                                          
                                          * Adding missing response schema.
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding default error response.
                                          
                                          * Review comments.
                                          
                                          * Remove extra comma
                                          
                                          * Addressing pending review changes.
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          Co-authored-by: Avinash Akka <[email protected]>
                                          
                                          * Add AssessPatches API (#9275)
                                          
                                          * Initial commit with updates to compute.json for assessPatches and softwarePatches
                                          
                                          * Add VirtualMachinesAssessPatches.json
                                          
                                          * Fix minor issues with softwarePatches
                                          
                                          * Updates to correct the example per oav
                                          
                                          * Remove GET and LIST softwarePatches
                                          
                                          * Remove unneeded list result
                                          
                                          * update description strings
                                          
                                          * Add kbid to spell check list. Include Prettier formating changes.
                                          
                                          * Update SoftwarePatch.InstallationState to AssessmentState
                                          
                                          * Remove extra properties from patch object array
                                          
                                          * Fix name of PublishedDate
                                          
                                          * Add generic error response
                                          
                                          * Add readonly, make rebootPending a boolean again
                                          
                                          * Remove LastModifiedDateTime from result object
                                          
                                          * Adding ExtensionsTimeBudget to new Api Version (#9319)
                                          
                                          * fixing encoding (+2 squashed commit)
                                          
                                          Squashed commit:
                                          
                                          [e73eef7] Prettier
                                          
                                          [68d011b] adding 201 response (+1 squashed commits)
                                          
                                          Squashed commits:
                                          
                                          [83f71bb48] Adding references (+1 squashed commits)
                                          
                                          Squashed commits:
                                          
                                          [d8ed894] updating GET example (+1 squashed commits)
                                          
                                          Squashed commits:
                                          
                                          [61920933d] fix (+1 squashed commits)
                                          
                                          Squashed commits:
                                          
                                          [f0151eb78] updated with extensionsTimeBudget
                                          
                                          * fixing file name
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          
                                          * Changes related to dedicated host group automatic placement (#9684)
                                          
                                          * Made changes for dedicated host group instance view
                                          
                                          * Added definitions for dedicated host group instance view
                                          
                                          * Made changes for SupportAutomaticPlacement
                                          
                                          * Made changes for assigned host
                                          
                                          * Made changes on properties.hostGroup
                                          
                                          * Added a missing comma
                                          
                                          * Addressed comments
                                          
                                          * Updated
                                          
                                          * Added assignedHost to VMScaleSetVMInstanceView
                                          
                                          * Addressed comments
                                          
                                          * Added minimum API version for assignedHost
                                          
                                          * Addressed comments
                                          
                                          * ModelAsString to false
                                          
                                          * Added exmples for VM
                                          
                                          * Added examples for VMSS
                                          
                                          * small fix
                                          
                                          * Addressed comments
                                          
                                          * Added missing parameter
                                          
                                          * Fixed examples
                                          
                                          * Add example for VMSS RunCommand (#9875)
                                          
                                          Co-authored-by: Jemal Abdulkadir <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          Co-authored-by: hari-bodicherla <[email protected]>
                                          Co-authored-by: Avinash <[email protected]>
                                          Co-authored-by: Avinash Akka <[email protected]>
                                          Co-authored-by: Mike Richmond <[email protected]>
                                          Co-authored-by: kamusta-msft <[email protected]>
                                          Co-authored-by: dochung4 <[email protected]>
                                          Co-authored-by: Atanas Koralski <[email protected]>
                                          00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Auto patch swagger change (Azure#9524)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065)
                                          
                                          * Adding in-guest vm patch propertyies to VM model
                                          
                                          * making the enum model as string
                                          
                                          * adding the change to end of the file for easy comparison
                                          
                                          * Fixing the name of the property
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065)
                                          
                                          * Adding in-guest vm patch propertyies to VM model
                                          
                                          * making the enum model as string
                                          
                                          * adding the change to end of the file for easy comparison
                                          
                                          * Fixing the name of the property
                                          
                                          * fixing merge conflict
                                          
                                          * fixing the checks
                                          
                                          * adding reference to the example
                                          
                                          * fixing the checks error
                                          
                                          * fixing the example validation
                                          
                                          * running prettier
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          
                                          * Revert the breaking change
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9520)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          
                                          * Added SecurityProfile to support Host Encryption for VM and Scaleset resources - Changes reviewed in PR: 9366 (Azure#9666)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * updated swagger
                                          
                                          * updated swagger
                                          
                                          * fixed the prettier issues
                                          
                                          * updated the documentation'
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * resolved
                                          
                                          * updated code
                                          
                                          * resolved conflicts
                                          
                                          * udpated comments
                                          
                                          * updated code
                                          
                                          * resolved prettier fix
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          
                                          * Adding new RetrieveBootDiagnosticsData.POST API. VM/VMSS managed boot diagnostics changes with examples. (Azure#9460)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065)
                                          
                                          * managed boot diagnostics changes.
                                          
                                          * Add new lines to the EOF.
                                          
                                          * Adding missing response schema.
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding default error response.
                                          
                                          * Review comments.
                                          
                                          * Remove extra comma
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          Co-authored-by: Avinash Akka <[email protected]>
                                          
                                          * Addressing minor corrections in examples related PR#9460 (Azure#9685)
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding DisallowedConfiguration property to VirtualMachineImageProperties (Azure#9065)
                                          
                                          * managed boot diagnostics changes.
                                          
                                          * Add new lines to the EOF.
                                          
                                          * Adding missing response schema.
                                          
                                          * Preparatory commit for compute 2020-06-01 API version
                                          
                                          * Adding default error response.
                                          
                                          * Review comments.
                                          
                                          * Remove extra comma
                                          
                                          * Addressing pending review changes.
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          Co-authored-by: Avinash Akka <[email protected]>
                                          
                                          * Add AssessPatches API (Azure#9275)
                                          
                                          * Initial commit with updates to compute.json for assessPatches and softwarePatches
                                          
                                          * Add VirtualMachinesAssessPatches.json
                                          
                                          * Fix minor issues with softwarePatches
                                          
                                          * Updates to correct the example per oav
                                          
                                          * Remove GET and LIST softwarePatches
                                          
                                          * Remove unneeded list result
                                          
                                          * update description strings
                                          
                                          * Add kbid to spell check list. Include Prettier formating changes.
                                          
                                          * Update SoftwarePatch.InstallationState to AssessmentState
                                          
                                          * Remove extra properties from patch object array
                                          
                                          * Fix name of PublishedDate
                                          
                                          * Add generic error response
                                          
                                          * Add readonly, make rebootPending a boolean again
                                          
                                          * Remove LastModifiedDateTime from result object
                                          
                                          * Adding ExtensionsTimeBudget to new Api Version (Azure#9319)
                                          
                                          * fixing encoding (+2 squashed commit)
                                          
                                          Squashed commit:
                                          
                                          [e73eef7] Prettier
                                          
                                          [68d011b] adding 201 response (+1 squashed commits)
                                          
                                          Squashed commits:
                                          
                                          [83f71bb48] Adding references (+1 squashed commits)
                                          
                                          Squashed commits:
                                          
                                          [d8ed894] updating GET example (+1 squashed commits)
                                          
                                          Squashed commits:
                                          
                                          [61920933d] fix (+1 squashed commits)
                                          
                                          Squashed commits:
                                          
                                          [f0151eb78] updated with extensionsTimeBudget
                                          
                                          * fixing file name
                                          
                                          Co-authored-by: Hyonho Lee <[email protected]>
                                          
                                          * Changes related to dedicated host group automatic placement (Azure#9684)
                                          
                                          * Made changes for dedicated host group instance view
                                          
                                          * Added definitions for dedicated host group instance view
                                          
                                          * Made changes for SupportAutomaticPlacement
                                          
                                          * Made changes for assigned host
                                          
                                          * Made changes on properties.hostGroup
                                          
                                          * Added a missing comma
                                          
                                          * Addressed comments
                                          
                                          * Updated
                                          
                                          * Added assignedHost to VMScaleSetVMInstanceView
                                          
                                          * Addressed comments
                                          
                                          * Added minimum API version for assignedHost
                                          
                                          * Addressed comments
                                          
                                          * ModelAsString to false
                                          
                                          * Added exmples for VM
                                          
                                          * Added examples for VMSS
                                          
                                          * small fix
                                          
                                          * Addressed comments
                                          
                                          * Added missing parameter
                                          
                                          * Fixed examples
                                          
                                          * Add example for VMSS RunCommand (Azure#9875)
                                          
                                          Co-authored-by: Jemal Abdulkadir <[email protected]>
                                          Co-authored-by: Sirajudeen Sahul Hameed <[email protected]>
                                          Co-authored-by: hari-bodicherla <[email protected]>
                                          Co-authored-by: Avinash <[email protected]>
                                          Co-authored-by: Avinash Akka <[email protected]>
                                          Co-authored-by: Mike Richmond <[email protected]>
                                          Co-authored-by: kamusta-msft <[email protected]>
                                          Co-authored-by: dochung4 <[email protected]>
                                          Co-authored-by: Atanas Koralski <[email protected]>
                                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                                          Labels
                                          ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
                                          Projects
                                          None yet
                                          Development

                                          Successfully merging this pull request may close these issues.

                                          5 participants