Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger changes for a new feature for generating LOA for expressRoutePorts resource #9217

Closed
wants to merge 133 commits into from
Closed

Conversation

umkanodi
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

nidhi-pathak and others added 30 commits April 8, 2020 15:49
* Logic Apps Swagger fixes

* Logic Apps Swagger fixes

* Logic apps swagger fix addressed CR comments.

* Logic apps swagger fix addressed CR comments II.

* Logic apps swagger fix addressed CR comments III.

* Logic apps swagger fix addressed CR comments IV

Co-authored-by: Nidhi Pathak <[email protected]>
…e/2019-08-01 (#8754)

* Initial private link swagger update

* try fix body issue

* Try fix ARM errors

* Address PR concerns

Co-authored-by: Mitch Webster <[email protected]>
* Added monitor subnet to SapMonitor model

* updated examples

* Fixed JSON

* fixed examples
* Add avocado ci-fix

* update note

* swagger PR pipeline
* add lint & breaking change to ci-fix.md

* update
…1 01 preview (#8951)

* Add Microsoft.KubernetesConfiguration to azure api specs

* New Readme Config File

* New Go Language Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New Ruby Language Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* Revert "Add Microsoft.KubernetesConfiguration to azure api specs"

This reverts commit e0889b2.

* Add Microsoft.KubernetesConfiguration specification

* PrettierCheck fixes

* Remove unused example file

* Delete settings.json

Deleting file added accidentally

* Address review comments

* Update output-folder for go config

* Mark Delete as Sync; and address review comment

* Updated Delete example to remove 202

* Updated readme of ruby and python for namespace values

* More updates for readme of ruby, python and typescript
* Added metadata field to SapMonitor provider instance

* fixed examples
* The APIs in WorkspaceAcl.json have been replaced with the APIs in role.json and roleAssignment.json.

* Change roleAssignment to remove the dependency of workspaceAcl.json

Co-authored-by: Zhenyu Zhou <[email protected]>
…less service and ApplicationTypeVersionsCleanupPolicy to cluster (#8944)

Co-authored-by: Alfredo Santamaria Gomez <[email protected]>
Use separate line for prettier check guide as one line of command doesn't work on cmd
…ior (Phase 2) (#8990)

* Update swagger for missing properties

* Revert "Update swagger for missing properties"

This reverts commit dc74330.

* Add provisioningOperation property to DeploymentOperation object

Co-authored-by: Filiz Topatan <[email protected]>
* return options.throughput in response for runtime resources

* update configuration files to account for new api version

* suppress provider pascal case errors

Co-authored-by: Sam Hurd <[email protected]>
* Generate new folder

* Add new API version

* Update examples dates

* Add MSI info

* Add PrivateEndpoints info

* Fix Json

* Updates readme

* prettier

* Fix errors and warnings

* Fix examples

* Fix DELETE operation for PrivateEndpoints

* Add 204 status code to DELETE example

* Add ID to routing endpoints

* Add new APIs per feedback and other updates

* Fix build errors

* Fix more build errors

* Prettify example file

Co-authored-by: Juan Carpio Castellanos <[email protected]>
Co-authored-by: Sridhar Kintali <[email protected]>
… public swagger (#8932)

* add allowLargeResults/azureFileConnector/fileFilter

* remove required

* remove allowLargeResults, add prefix to Azurefile

* add partitionRootPath

Co-authored-by: Haoran Sun <[email protected]>
* Add swagger spec for custom domain of appplatform

* Sub resource custom domain, Spring/apps/domains.
* Sub resource certificate, Spring/certificates.
* Action for certificates/validate.

Signed-off-by: Pan Li <[email protected]>

* Add pagable for list.

Signed-off-by: Pan Li <[email protected]>

* Add httpsonly and fqdn to app.

Signed-off-by: Pan Li <[email protected]>

* Resolve comments.

Signed-off-by: Pan Li <[email protected]>
This was referenced Apr 27, 2020
@umkanodi umkanodi closed this Apr 27, 2020
@umkanodi umkanodi reopened this Apr 27, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@umkanodi
Copy link
Contributor Author

Hi Team,
Something went wrong when I incorporate the suggested changes in a file and pushed it. Now its started showing close to 600 files. I am assuming it is due to some issues in my forked repo. After trying to get the real issue, I decided to close the PR and raise a new one.

Thanks,
Umesh Kanodia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.