Added monitor subnet to SapMonitor model #8915

PakDLiu · 2020-04-01T22:23:10Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-04-01T22:23:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-04-01T22:23:54Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-04-01T22:24:42Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ff1fa6d with merge commit 4e19db6. SDK Automation 13.0.17.20200326.3
️✔️sdk/hanaonazure/mgmt-v2017_11_03_preview [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-04-01T22:24:44Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ff1fa6d with merge commit 4e19db6. SDK Automation 13.0.17.20200326.3
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-04-01T22:24:44Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ff1fa6d with merge commit 4e19db6. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-hanaonazure [Logs] [Release SDK Changes]

azure-arm-hanaonazure-3.0.0.tgz

[npmPack] npm WARN lifecycle @azure/[email protected]~prepack: cannot run in wd @azure/[email protected] npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/hanaonazure/arm-hanaonazure)

openapi-sdkautomation · 2020-04-01T22:24:46Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ff1fa6d with merge commit 4e19db6. SDK Automation 13.0.17.20200326.3
⚠️preview/hanaonazure/mgmt/2017-11-03-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-04-01T22:24:57Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-01T22:25:03Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

ArcturusZhang · 2020-04-02T04:40:14Z

Hi @PakDLiu could you please provide some information about the breaking change? Adding properties to response is identified as a breaking change by the breaking change tool.
The new field subnet is added only to responses, does this mean that field should be readonly?

PakDLiu · 2020-04-02T04:42:47Z

Yes, I added the new field: monitorSubnet.
It is required in the request.
It should also be returned in the response

majastrz · 2020-04-02T05:25:57Z

...naonazure/resource-manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/hanaonazure.json

@@ -617,6 +617,10 @@
          "readOnly": true,
          "type": "string",
          "description": "The version of the payload running in the Collector VM"
+        },
+        "monitorSubnet": {


monitorSubnet [](start = 9, length = 13)

Is this property required?

Then this is a breaking change that should be done in a new API version.

In reply to: 402059679 [](ancestors = 402059679)

This is still a preview API version and the API is still in flux.
We also know that no one outside of our team is using this API yet.

Got it. That's fine then.

In general, I would recommend working in a development branch in the public or private Swagger repo when the API is still in flux. What's in master branch in this repo is considered public and available for use regardless of the -preview suffix on the API version.

In reply to: 402062621 [](ancestors = 402062621)

I see, thanks!
Will do that in the future

majastrz · 2020-04-02T05:27:11Z

...ce-manager/Microsoft.HanaOnAzure/preview/2020-02-07-preview/examples/SapMonitors_Create.json

@@ -16,7 +16,8 @@
        "enableCustomerAnalytics": true,
        "logAnalyticsWorkspaceArmId": "",
        "logAnalyticsWorkspaceId": "",
-        "logAnalyticsWorkspaceSharedKey": ""
+        "logAnalyticsWorkspaceSharedKey": "",


"" [](start = 42, length = 2)

Can you provide example resource IDs for all the properties that are being specified. "" is not really helpful to users. (This comment applies to all examples and properties in the examples.)

majastrz

Please update examples to make them more meaningful, but the change looks good to me. Signed off from ARM side.

azure-pipelines · 2020-04-02T18:15:40Z

Azure Pipelines successfully started running 1 pipeline(s).

ArcturusZhang · 2020-04-03T03:46:55Z

Hi @PakDLiu could you please resolve the CI failures? (Except the breaking change since it is acceptable for a preview API) then this will be good to merge, thanks

azure-pipelines · 2020-04-03T04:10:27Z

Azure Pipelines successfully started running 1 pipeline(s).

PakDLiu · 2020-04-03T04:35:57Z

Didn't notice there were other errors.
Fixed

ArcturusZhang

LGTM 👍

azure-pipelines · 2020-04-08T18:04:35Z

Azure Pipelines successfully started running 1 pipeline(s).

* Added monitor subnet to SapMonitor model * updated examples * Fixed JSON * fixed examples

Added monitor subnet to SapMonitor model

5be6a58

openapi-assignment-bot bot assigned ArcturusZhang Apr 1, 2020

This was referenced Apr 1, 2020

[AutoPR @azure/arm-hanaonazure] Added monitor subnet to SapMonitor model AzureSDKAutomation/azure-sdk-for-js#954

Closed

[AutoPR sdk/hanaonazure/mgmt-v2017_11_03_preview] Added monitor subnet to SapMonitor model AzureSDKAutomation/azure-sdk-for-java#2548

Closed

ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 2, 2020

majastrz reviewed Apr 2, 2020

View reviewed changes

majastrz approved these changes Apr 2, 2020

View reviewed changes

updated examples

196970a

Fixed JSON

8eb4ad1

ArcturusZhang approved these changes Apr 8, 2020

View reviewed changes

fixed examples

ff1fa6d

akning-ms merged commit 4e19db6 into Azure:master Apr 9, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Added monitor subnet to SapMonitor model (Azure#8915)

0b52b71

* Added monitor subnet to SapMonitor model * updated examples * Fixed JSON * fixed examples

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added monitor subnet to SapMonitor model #8915

Added monitor subnet to SapMonitor model #8915

PakDLiu commented Apr 1, 2020

azure-pipelines bot commented Apr 1, 2020

azuresdkci commented Apr 1, 2020

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

ArcturusZhang commented Apr 2, 2020

PakDLiu commented Apr 2, 2020

majastrz Apr 2, 2020

PakDLiu Apr 2, 2020

majastrz Apr 2, 2020

PakDLiu Apr 2, 2020

majastrz Apr 2, 2020

PakDLiu Apr 2, 2020

majastrz Apr 2, 2020

PakDLiu Apr 2, 2020

majastrz left a comment

azure-pipelines bot commented Apr 2, 2020

ArcturusZhang commented Apr 3, 2020

azure-pipelines bot commented Apr 3, 2020

PakDLiu commented Apr 3, 2020

ArcturusZhang left a comment

azure-pipelines bot commented Apr 8, 2020

Added monitor subnet to SapMonitor model #8915

Added monitor subnet to SapMonitor model #8915

Conversation

PakDLiu commented Apr 1, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Apr 1, 2020

azuresdkci commented Apr 1, 2020

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-net - Release

ArcturusZhang commented Apr 2, 2020

PakDLiu commented Apr 2, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Apr 2, 2020

ArcturusZhang commented Apr 3, 2020

azure-pipelines bot commented Apr 3, 2020

PakDLiu commented Apr 3, 2020

ArcturusZhang left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Apr 8, 2020

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading